Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: aggregate session from laps #130

Merged
merged 4 commits into from
Nov 12, 2024
Merged

fix: aggregate session from laps #130

merged 4 commits into from
Nov 12, 2024

Conversation

muktihari
Copy link
Member

Currently, aggregator does not work if the struct has embedded struct/pointer, need to aggregate it directly.

I found this issue when trimming an activity and found out that some of session's fields are missing.

@muktihari muktihari added the bug Something isn't working label Nov 9, 2024
@muktihari muktihari self-assigned this Nov 9, 2024
@muktihari muktihari merged commit 71ce71c into openivity:dev Nov 12, 2024
1 check passed
muktihari added a commit that referenced this pull request Nov 12, 2024
@muktihari
Release 12-11-2024 (#132)
11f8b47 
* fix: wrong conceal or trim marker (#126)

* fix: aggregate session from laps (#130)

* fix: aggregate fill session

* feat: enable distance and speed removal (#131)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raditzlawliet raditzlawliet Awaiting requested review from raditzlawliet

Assignees

@muktihari muktihari

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@muktihari