Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: export GPX and TCX wrong DeviceName #107

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

muktihari
Copy link
Member

@muktihari muktihari commented Jun 16, 2024

  • When user changes the deviceName manually (text input), we will try to match deviceName from user's input into our database so we can get a valid manufacturerId and ProductId in case user wants to export to FIT later, however we do not specify a fallback when the mapping value is not found, for GPX and TCX only the deviceName is required.
  • This is not related to the issue, but let's just include it: bump xmltokenizer to v0.0.2

Let's do patch release after this 😅

@muktihari muktihari added the bug Something isn't working label Jun 16, 2024
@muktihari muktihari requested a review from raditzlawliet June 16, 2024 16:04
@muktihari muktihari self-assigned this Jun 16, 2024
Copy link
Member

@raditzlawliet raditzlawliet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅

@muktihari muktihari merged commit 813c008 into dev Jun 17, 2024
1 check passed
@muktihari muktihari deleted the fix/export-gpx-tcx-device-name branch June 17, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants