V1.1.17 #597
Open
V1.1.17 #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -11,7 +11,7 @@ RUN make build_ui | |||
| ###################################### | |||
| # Prepare go_builder | |||
| ###################################### | |||
| FROM golang:1.21-alpine as go_builder | |||
| FROM golang:1.23.4-alpine as go_builder | |||
There was a problem hiding this comment.
Does something from 1.21-alpine in go_builder end up in the final image and get scanned? I'd expect that we have to update the alpine used in the final image instead on line 21.
(unless, that ends up using the same alpine as go_builder, since it doesn't specify...???)
There was a problem hiding this comment.
Go dependencies are resolved and build from the alpine in line 14 as the Run make build is executed on line 19.
Line 21 alpine is just for fulfilling runtime dependencies and is very light weight.
There was a problem hiding this comment.
Also, FROM alpine would anyways pull the latest stable image of alpine. So i believe it is not mandatory to mention the version there?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: