Merge pull request #337 from checkr/zz/add-404-get-flag-test

Add 404 get flag test
openflagr · Mar 19, 2020 · d8436c1 · d8436c1
2 parents 0febaaf + 50c40f5
commit d8436c1
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/pkg/handler/crud_test.go b/pkg/handler/crud_test.go
@@ -53,6 +53,11 @@ func TestCrudFlags(t *testing.T) {
 		assert.NotZero(t, res.(*flag.GetFlagOK).Payload.Key)
 	})
 
+	t.Run("it should return 404 not found if flag is not there", func(t *testing.T) {
+		res = c.GetFlag(flag.GetFlagParams{FlagID: int64(4444444)})
+		assert.NotZero(t, res.(*flag.GetFlagDefault))
+	})
+
 	t.Run("it should be able to get preloaded segments and variants", func(t *testing.T) {
 		c.CreateSegment(segment.CreateSegmentParams{
 			FlagID: int64(1),