Merge pull request #134 from checkr/zz/add-offset-support

Add offset support
openflagr · Jun 26, 2018 · 39caa34 · 39caa34
2 parents 7cf9a20 + 0f71984
commit 39caa34
Show file tree

Hide file tree

Showing 8 changed files with 74 additions and 5 deletions.
diff --git a/docs/api_docs/bundle.yaml b/docs/api_docs/bundle.yaml
@@ -4,7 +4,7 @@ info:
     Flagr is a feature flagging, A/B testing and dynamic configuration
     microservice
   title: Flagr
-  version: 1.0.0
+  version: 1.0.7
 tags:
   - name: flag
     description: Everything about the flag
@@ -60,6 +60,13 @@ paths:
           name: description_like
           type: string
           description: return flags partially matching given description
+        - in: query
+          name: offset
+          type: integer
+          format: int64
+          description: >-
+            return flags given the offset, it should usually set together with
+            limit
       responses:
         '200':
           description: list all the flags

diff --git a/pkg/handler/crud.go b/pkg/handler/crud.go
@@ -81,6 +81,9 @@ func (c *crud) FindFlags(params flag.FindFlagsParams) middleware.Responder {
 	if params.Limit != nil {
 		q = q.Limit(int(*params.Limit))
 	}
+	if params.Offset != nil {
+		q = q.Offset(int(*params.Offset))
+	}
 
 	err := q.All(&fs)
 	if err != nil {

diff --git a/swagger/flags.yaml b/swagger/flags.yaml
@@ -20,6 +20,11 @@ get:
       name: description_like
       type: string
       description: return flags partially matching given description
+    - in: query
+      name: offset
+      type: integer
+      format: int64
+      description: return flags given the offset, it should usually set together with limit
   responses:
     200:
       description: list all the flags

diff --git a/swagger/index.yaml b/swagger/index.yaml
@@ -3,7 +3,7 @@ swagger: "2.0"
 info:
   description: Flagr is a feature flagging, A/B testing and dynamic configuration microservice
   title: Flagr
-  version: 1.0.0
+  version: 1.0.7
 tags:
   - name: flag
     description: Everything about the flag

diff --git a/swagger_gen/restapi/doc.go b/swagger_gen/restapi/doc.go
diff --git a/swagger_gen/restapi/embedded_spec.go b/swagger_gen/restapi/embedded_spec.go
diff --git a/swagger_gen/restapi/operations/flag/find_flags_parameters.go b/swagger_gen/restapi/operations/flag/find_flags_parameters.go
diff --git a/swagger_gen/restapi/operations/flag/find_flags_urlbuilder.go b/swagger_gen/restapi/operations/flag/find_flags_urlbuilder.go