This repository has been archived by the owner on Feb 14, 2021. It is now read-only.
Alternate multiresult implementation #68
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
why closing? i think it might be better implementation then current ;) |
|
I can reopen (I got the button). I was just thinking of the work to review in comparison to the benefits. |
lexfrl
force-pushed
the
master
branch
2 times, most recently
from
efb0994 to
4d47596
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I was updating a branch from months ago and I have seen that I did an alternate implementation for multiresult at the time. I extract it from other changes (partial support for u8 u16 and support for Byte array) to see if it works, seems to pass the test locally .
I just PR for information (to communicate this other version), please don't merge this PR (unless the support for tuple of bigger size than 6 is wanted).