Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade to support solidity >= 0.5.0, web3 >= 1.0.0, truffle >= 5.0.0 #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

upgrade to support solidity >= 0.5.0, web3 >= 1.0.0, truffle >= 5.0.0 #14

wants to merge 1 commit into from

Conversation

madwiki
Copy link

@madwiki madwiki commented Jan 14, 2020 •
edited
Loading

2031578998535_ pic_hd

tomusdrw
tomusdrw approved these changes Jan 21, 2020
View reviewed changes
Copy link
Contributor

@tomusdrw tomusdrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @madwiki! Looks good to me, I'm not a Solidity expert though. Would be nice to make the variable names more descriptive.

test/owned_set.js Show resolved Hide resolved
test/relayed_owned_set.js Show resolved Hide resolved
test/relayed_owned_set.js Show resolved Hide resolved
@itsdevbear
Copy link

dead repo and I am not on the team, but LGTM hahahaha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomusdrw tomusdrw tomusdrw approved these changes

@andresilva andresilva Awaiting requested review from andresilva andresilva is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@madwiki @itsdevbear @tomusdrw