Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added folder with solidity 0.5.0 compatible validator set contracts #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Genysys
Copy link

@Genysys Genysys commented Nov 23, 2018

Fixed breaking changes to validator set contracts. Left old folder as most people are still on 0.4.*

@coveralls
Copy link

Pull Request Test Coverage Report for Build 96

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 91: 0.0%
Covered Lines: 77
Relevant Lines: 77

💛 - Coveralls

Copy link
Collaborator

@andresilva andresilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! 👍 Instead of creating a new folder what do you think about us creating a solidity-0.5.0 branch for this. It would be easier to diff the changes and it would also allow us to update truffle to the latest version which I think uses Solidity v0.5.0, this will make sure that the whole test suite is run against the updated contracts in this PR. We could also add a note in the README (of the master branch) pointing to the branch that supports Solidity v0.5.0.

@Genysys
Copy link
Author

Genysys commented Nov 28, 2018

Sounds good happy to make those changes @andresilva

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants