This repository has been archived by the owner on May 24, 2022. It is now read-only.
Fix #77: don't show password in plaintext in console #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amaury1093
reviewed
Dec 31, 2018
There was a problem hiding this comment.
@yjkimjunior I agree with you, I don't think it's a security issue neither, because the password (wrong or correct one) is always shown in the network tab. But let's still merge this, if anything it'll make the users feel safer.
Can we instead show "***" instead of the password?
packages/api/src/transport/ws/ws.js
Outdated
| @@ -261,6 +261,11 @@ class Ws extends JsonRpcBase { | |||
|
|
|||
| // Don't print error if request rejected or not is not yet up... | |||
| if (!/(rejected|not yet up)/.test(result.error.message)) { | |||
| var dangerous_methods = ['signer_confirmRequest', 'signer_confirmRequestWithToken']; | |||
packages/api/src/transport/ws/ws.js
Outdated
| @@ -261,6 +261,11 @@ class Ws extends JsonRpcBase { | |||
|
|
|||
| // Don't print error if request rejected or not is not yet up... | |||
| if (!/(rejected|not yet up)/.test(result.error.message)) { | |||
| var dangerous_methods = ['signer_confirmRequest', 'signer_confirmRequestWithToken']; | |||
| if (dangerous_methods.includes(method)) { | |||
| params.pop(); | |||
There was a problem hiding this comment.
Don't use pop(), since it alters params, which might be used somewhere else
amaury1093
reviewed
Jan 2, 2019
| let safe_params; | ||
| if (dangerous_methods.includes(method)) { | ||
| safe_params = params.slice(); | ||
| safe_params[params.length - 1] = '***'; |
There was a problem hiding this comment.
Let's add a comment somewhere here, to tell future devs what we're doing here, it might not be obvious at 1st sight.
Co-Authored-By: yjkimjunior <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#77
@ltfschoen, I've made this edit to address the downstream bug in Fether - openethereum/fether#317
I'm not convinced this is actually a security bug however since:
a) it only logs when the password is incorrect, and
b) in production the developer console would not be accessible,
though of course, I'm all ears to learning about why it actually is an issue.