-
Notifications
You must be signed in to change notification settings - Fork 40
Conversation
- fix path for @parity/light.js (package.json) - update dependencies - skipped (breaking changes for 2.x): react-scripts, react-app-rewired (-> breaks decorators) - remove hint about window.parity (not working) - make font sans-serif
It looks like @bwasty signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
1 similar comment
It looks like @bwasty signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
Thanks a lot! Yes, the example might have been left out a bit, thanks for having a look.
You're right, I wanted to show "look how cool this lib is with decorators", but for such a simple example, it might be better to drop them. Would you mind doing this in this PR? At the same time remove react-app-rewired and update to CRA2 (plain JS). Cheers! |
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tried, looks good! Thanks for the PR
I tried out the react example and made some fixes/improvements:
* About the decorators: I would suggest removing them or converting to TypeScript. I think such a simple example should use a 'plain' create-react-app setup, without things like
react-app-rewired
/config overrides.