add comment explaining the issue

openethereum · Jan 2, 2019 · 71fbf5a · 71fbf5a
1 parent a577e2b
commit 71fbf5a
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/packages/api/src/transport/ws/ws.js b/packages/api/src/transport/ws/ws.js
@@ -261,6 +261,9 @@ class Ws extends JsonRpcBase {
 
         // Don't print error if request rejected or not is not yet up...
         if (!/(rejected|not yet up)/.test(result.error.message)) {
+          // fether Issue #317
+          // js-libs Issue #77 Masks the password param when logging error to console on methods that contain it as a param.
+          // e.g. ["0x2",{},"myincorrectpassword"] -> ["0x2",{},"***"]
           const dangerous_methods = ['signer_confirmRequest', 'signer_confirmRequestWithToken'];
           let safe_params;
           if (dangerous_methods.includes(method)) {