-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Remove yanked codecov package (and coverage upload) #886
Conversation
I guess this repo isn't using the newer github action, but adding that can be a different task if we decide to continue with codecov.
Hmm, looks like it was actually still invoking codecov: xqueue/.github/workflows/ci.yml Line 37 in b8ef63b
Maybe we want to just remove that coverage step for now. |
Can it just do what other services are doing? |
It's doing all of its tests inside a docker container for some reason. The other repos that use the coverage action are able to do so because they're not running tests that way. |
Maybe just drop coverage and add an issue for changing this to better match other repos? |
Yeah, I think that's the best route. It looks like we should be able to generate a coverage report inside the container, copy the files out of the container, and then run the action -- but I'd like to figure that out a different day. :-) |
Created tracking issue: #887 |
#887 tracks restoring and fixing coverage testing.
@robrap Ready for re-review. |
Stop trying to install the deprecated (and now yanked) codecov package. Also remove the CI step that was trying to use it, since we'd prefer to unblock CI now and restore coverage later. #887 tracks restoring coverage testing.