Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update customFileHeader during tokens build #3371

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

adamstankiewicz
Copy link
Member

Description

Updates the custom file header auto-generated in output CSS files from the build-tokens NPM script:

  • Removes the erroneous "while transforming design tokens" message.
  • Updates <root> to <PARAGON_ROOT> as this message is output in custom brand packages, too, which might not define a README.

Old

/**
 * Do not edit directly, this file was auto-generated. while transforming design tokens.
 * See <root>/tokens/README.md for more details.
 */

New

/**
 * Do not edit directly, this file was auto-generated.
 * See <PARAGON_ROOT>/tokens/README.md for more details.
 */

Deploy Preview

N/A

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please request an a11y review for the PR in the #wg-paragon Open edX Slack channel.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

Copy link

netlify bot commented Dec 18, 2024

Deploy Preview for paragon-openedx-v23 ready!

Name Link
🔨 Latest commit fc525b7
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx-v23/deploys/6762e20517ed390008fc18d9
😎 Deploy Preview https://deploy-preview-3371--paragon-openedx-v23.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.87%. Comparing base (92c43c3) to head (fc525b7).
Report is 2 commits behind head on release-23.x.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-23.x    #3371   +/-   ##
=============================================
  Coverage         93.87%   93.87%           
=============================================
  Files               232      232           
  Lines              3937     3937           
  Branches            902      929   +27     
=============================================
  Hits               3696     3696           
+ Misses              237      234    -3     
- Partials              4        7    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@brian-smith-tcril brian-smith-tcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Contributor

@PKulkoRaccoonGang PKulkoRaccoonGang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@adamstankiewicz adamstankiewicz merged commit 19cb46a into release-23.x Dec 18, 2024
10 checks passed
@adamstankiewicz adamstankiewicz deleted the ags/update-default-file-header branch December 18, 2024 17:32
@openedx-semantic-release-bot

🎉 This PR is included in version 23.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants