Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-46] docs: added support for internal md pages for components #2875

Conversation

PKulkoRaccoonGang
Copy link
Contributor

Description

  • added support for internal md pages for components.

Deploy Preview

Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks openedx-webhooks added the blended PR is managed through 2U's blended developmnt program label Nov 30, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Nov 30, 2023

Thanks for the pull request, @PKulkoRaccoonGang!

This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate.

@PKulkoRaccoonGang PKulkoRaccoonGang marked this pull request as draft November 30, 2023 09:19
Copy link

netlify bot commented Nov 30, 2023

Deploy Preview for paragon-openedx ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 6f6b927
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/6575cb58b64c4600080de93b
😎 Deploy Preview https://deploy-preview-2875--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f50fddd) 92.89% compared to head (6f6b927) 92.83%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2875      +/-   ##
==========================================
- Coverage   92.89%   92.83%   -0.07%     
==========================================
  Files         235      235              
  Lines        4338     4245      -93     
  Branches     1056     1032      -24     
==========================================
- Hits         4030     3941      -89     
+ Misses        304      300       -4     
  Partials        4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/support-for-internal-md-pages-for-components branch 3 times, most recently from a4a78a8 to 4580843 Compare December 10, 2023 14:26
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/support-for-internal-md-pages-for-components branch from 4580843 to 6f6b927 Compare December 10, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blended PR is managed through 2U's blended developmnt program
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants