Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-46] refactor: removed semantic release version preview #2871

Conversation

PKulkoRaccoonGang
Copy link
Contributor

@PKulkoRaccoonGang PKulkoRaccoonGang commented Nov 28, 2023

Description

  • removed semantic release version preview.

Issue: #2778

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks openedx-webhooks added the blended PR is managed through 2U's blended developmnt program label Nov 28, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Nov 28, 2023

Thanks for the pull request, @PKulkoRaccoonGang!

When this pull request is ready, tag your edX technical lead.

Copy link

netlify bot commented Nov 28, 2023

Deploy Preview for paragon-openedx ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 81b5e83
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/65721953dbac6400082dc0a8
😎 Deploy Preview https://deploy-preview-2871--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@PKulkoRaccoonGang
Copy link
Contributor Author

PKulkoRaccoonGang commented Nov 28, 2023

@adamstankiewicz I made several attempts to launch a semantic release preview for the pull request branch, but they were not successful. This functionality can be implemented without problems for the main branches (master, alpha, etc.), but with pull requests, it most likely does not work correctly.

I'm removing this CI step for new pull requests, but this semantic release version preview will still be available during the release.

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (71405c1) 92.83% compared to head (81b5e83) 92.83%.
Report is 14 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2871   +/-   ##
=======================================
  Coverage   92.83%   92.83%           
=======================================
  Files         235      235           
  Lines        4240     4244    +4     
  Branches     1029     1031    +2     
=======================================
+ Hits         3936     3940    +4     
  Misses        300      300           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@viktorrusakov
Copy link
Contributor

@PKulkoRaccoonGang I think I found a workaround for this, can you try to remove Extract branch name step and modify Preview semantic-release version as follows:

- name: Preview semantic-release version
  env:
    GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
    NPM_TOKEN: ${{ secrets.SEMANTIC_RELEASE_NPM_TOKEN }}
  run: |
    git checkout $GITHUB_HEAD_REF
    unset GITHUB_ACTIONS
    npx semantic-release --dry-run --no-ci --branches=$GITHUB_HEAD_REF

@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/removed-semantic-realise-version branch from f3ff3fb to 5fda7a1 Compare December 6, 2023 21:10
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/removed-semantic-realise-version branch from 5fda7a1 to 45c2e09 Compare December 6, 2023 21:53
@PKulkoRaccoonGang PKulkoRaccoonGang marked this pull request as draft December 6, 2023 22:46
@viktorrusakov viktorrusakov force-pushed the Peter_Kulko/removed-semantic-realise-version branch 9 times, most recently from ba3b39f to ec95d76 Compare December 7, 2023 16:25
@viktorrusakov viktorrusakov force-pushed the Peter_Kulko/removed-semantic-realise-version branch from ec95d76 to 0a7d0c7 Compare December 7, 2023 16:33
@viktorrusakov viktorrusakov marked this pull request as ready for review December 7, 2023 19:18
@viktorrusakov viktorrusakov merged commit b28ecea into openedx:master Dec 7, 2023
10 checks passed
@openedx-semantic-release-bot

🎉 This PR is included in version 21.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@openedx-semantic-release-bot

🎉 This PR is included in version 22.0.0-alpha.20 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blended PR is managed through 2U's blended developmnt program released on @alpha released
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[discovery] Attempt to get the semantic release version preview on CI working again
4 participants