-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BD-46] refactor: removed semantic release version preview #2871
[BD-46] refactor: removed semantic release version preview #2871
Conversation
Thanks for the pull request, @PKulkoRaccoonGang! When this pull request is ready, tag your edX technical lead. |
✅ Deploy Preview for paragon-openedx ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
@adamstankiewicz I made several attempts to launch a semantic release preview for the pull request branch, but they were not successful. This functionality can be implemented without problems for the main branches (master, alpha, etc.), but with pull requests, it most likely does not work correctly. I'm removing this CI step for new pull requests, but this semantic release version preview will still be available during the release. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2871 +/- ##
=======================================
Coverage 92.83% 92.83%
=======================================
Files 235 235
Lines 4240 4244 +4
Branches 1029 1031 +2
=======================================
+ Hits 3936 3940 +4
Misses 300 300
Partials 4 4 ☔ View full report in Codecov by Sentry. |
@PKulkoRaccoonGang I think I found a workaround for this, can you try to remove - name: Preview semantic-release version
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
NPM_TOKEN: ${{ secrets.SEMANTIC_RELEASE_NPM_TOKEN }}
run: |
git checkout $GITHUB_HEAD_REF
unset GITHUB_ACTIONS
npx semantic-release --dry-run --no-ci --branches=$GITHUB_HEAD_REF |
f3ff3fb
to
5fda7a1
Compare
5fda7a1
to
45c2e09
Compare
ba3b39f
to
ec95d76
Compare
ec95d76
to
0a7d0c7
Compare
🎉 This PR is included in version 21.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 22.0.0-alpha.20 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Issue: #2778
Merge Checklist
example
app?wittjeff
andadamstankiewicz
as reviewers on this PR.Post-merge Checklist