Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Peter kulko/sync alpha to master branch #2730

Closed
wants to merge 13 commits into from
Closed

Peter kulko/sync alpha to master branch #2730

wants to merge 13 commits into from

Conversation

PKulkoRaccoonGang
Copy link
Contributor

Description

Include a description of your changes here, along with a link to any relevant Jira tickets and/or Github issues.

Deploy Preview

Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

khudym and others added 13 commits October 12, 2023 16:26
@khudym @PKulkoRaccoonGang
test: migrate tests to react-testing-library (openedx#2581)
c00d2c9 
* refactor: move enzyme to react testing library

* feat: rewriting tests from Enzyme to RTL

* refactor: update tests 2

* refactor: rewrite tests using react testing library

* refactor: rewrite test using react testing library 2part

* refactor: refactor after review part 1

* refactor: replace fireEvent with userEvent where it is possible

* fix: fix console errors

---------

Co-authored-by: monteri <lansevermore>
Co-authored-by: PKulkoRaccoonGang <[email protected]>
Co-authored-by: Kyrylo Hudym-Levkovych <[email protected]>
@github-actions
docs: update dependent-usage.json (openedx#2711)
8efc53e
@cintnguyen
fix: run leave control logic when tabbing out of autosuggest (openedx…
5521493 
…#2663)
@cintnguyen
fix: allows focus to return to autosuggest input after hitting esc (o…
34f055a 
…penedx#2556)
@brian-smith-tcril
fix: use kebab-case-ids in autosuggest esc test (openedx#2717)
9face09
@PKulkoRaccoonGang
fix: avoid duplicate onChange calls in FormRadioSet and FormCheckboxS…
a395042 
…et (openedx#2705)

* fix: fixed duplicate calls in FormRadioSet and FormCheckboxSet

* refactor: added new tests

* refactor: refactoring after review
@github-actions
docs: update dependent-usage.json (openedx#2720)
2fcd16f
@github-actions
docs: update dependent-usage.json (openedx#2721)
77f33dc
@github-actions
docs: update dependent-usage.json (openedx#2722)
98f7822
@github-actions
docs: update dependent-usage.json (openedx#2724)
60faf0c
@github-actions
docs: update dependent-usage.json (openedx#2725)
89d6d08
@github-actions
docs: update dependent-usage.json (openedx#2727)
6ee88e4
@PKulkoRaccoonGang
Merge remote-tracking branch 'origin/master' into HEAD
e750b91 
# Conflicts:
#	package-lock.json
#	package.json
#	src/Button/deprecated/Button.test.jsx
#	src/CheckBox/CheckBox.test.jsx
#	src/CheckBoxGroup/CheckBoxGroup.test.jsx
#	src/Dropdown/deprecated/Dropdown.test.jsx
#	src/Dropdown/deprecated/__snapshots__/Dropdown.test.jsx.snap
#	src/Fieldset/Fieldset.test.jsx
#	src/Fieldset/index.jsx
#	src/Input/input.test.jsx
#	src/InputText/InputText.test.jsx
#	src/ListBox/ListBox.test.jsx
#	src/ListBoxOption/ListBoxOption.test.jsx
#	src/Modal/index.jsx
#	src/RadioButtonGroup/RadioButtonGroup.test.jsx
#	src/SearchField/__snapshots__/SearchField.test.jsx.snap
#	src/StatusAlert/StatusAlert.test.jsx
#	src/Table/Table.test.jsx
#	src/Table/index.jsx
#	src/Tabs/deprecated/Tabs.test.jsx
#	src/ValidationFormGroup/ValidationFormGroup.test.jsx
#	src/ValidationFormGroup/__snapshots__/ValidationFormGroup.test.jsx.snap
#	src/ValidationFormGroup/index.jsx
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 18, 2023
@netlify
Copy link

netlify bot commented Oct 18, 2023 •
edited
Loading

✅ Deploy Preview for paragon-openedx ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit e750b91
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/65302ee7c972550007b2f735
😎 Deploy Preview https://deploy-preview-2730--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@openedx-webhooks
Copy link

openedx-webhooks commented Oct 18, 2023 •
edited
Loading

Thanks for the pull request, @PKulkoRaccoonGang! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate.

@PKulkoRaccoonGang PKulkoRaccoonGang marked this pull request as draft October 18, 2023 19:15
@openedx-webhooks
Copy link

@PKulkoRaccoonGang Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@PKulkoRaccoonGang @openedx-webhooks @khudym @cintnguyen @brian-smith-tcril