docs: ADR to use React Query instead of Redux, update general JS/TS guidance

[bradenmacdonald]

• Changed guidance on React state/data loading to recommend React Query instead of Redux
• Updated JavaScript/TypeScript guidance

Previous discussions etc:

• https://openedx.atlassian.net/wiki/spaces/BPL/pages/3852632086/Typescript+and+React-Query+for+api+usage.
• https://openedx.atlassian.net/wiki/spaces/AC/pages/3791290378/tanstack+react-query+An+overview
• My conference lightning talk on React Query

Preview this at https://open-edx-proposals--616.org.readthedocs.build/en/616/best-practices/oep-0067-bp-tools-and-technology.html

[openedx-webhooks]

Thanks for the pull request, @bradenmacdonald!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

• If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
  • This process (including the steps you'll need to take) is documented here.
• If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

• Dependencies

  This PR must be merged before / after / at the same time as ...

• Blockers

  This PR is waiting for OEP-1234 to be accepted.

• Timeline information

  This PR must be merged by XX date because ...

• Partner information

  This is for a course on edx.org.

• Supporting documentation
• Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @sarina. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

• Overview of Review Process for Community Contributions
• Pull Request Status Guide
• Making changes to your pull request

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

• The size and impact of the changes that it introduces
• The need for product review
• Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

[sarina]

It would be great to have something in this tree, I think: https://docs.openedx.org/en/latest/developers/references/developer_guide/conventions/index.html that points to this OEP. Or maybe there's a better place within https://docs.openedx.org/en/latest/developers/references/developer_guide/index.html? What do you think?

[bradenmacdonald]

Sure. Maybe in both places?

[itsjeyd]

@sarina It looks like you already started reviewing this PR, so I went ahead and assigned the review to you. Let me know if that's not what you had in mind.

[sarina]

@bradenmacdonald yeah in both places sounds good.

@itsjeyd - I am the maintainer of this repo so I commented a bit on structure, but I'm not a frontend expert so Braden should seek to find a reviewer from that group.

[brian-smith-tcril]

This looks great! I'm 100% on board with recommending React Query, and the reasoning provided here is clear and persuasive.

I left one tiny non-blocking comment, but LGTM!

[bradenmacdonald]

yeah in both places sounds good.

@sarina Since those are in a different repo, I'll open a PR to link to this from both places once this PR has merged.

I think this should be good to merge soon, but I've posted on Slack one last time to see if anyone else wants to comment/review.

[arbrandes]

100%.

[adamstankiewicz]

Glad to see React Query make its way into the OEPs :)

[bradenmacdonald]

Thanks everyone!

[openedx-webhooks]

@bradenmacdonald 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.