Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: catalog-info.yaml should primarily use "Web" for icon #604

Merged
merged 1 commit into from
Jul 18, 2024
Merged

docs: catalog-info.yaml should primarily use "Web" for icon #604

merged 1 commit into from
Jul 18, 2024

Conversation

sarina
Copy link
Contributor

@sarina sarina commented Jul 4, 2024

Addresses #568

@sarina sarina requested review from feanil and robrap July 4, 2024 19:36
robrap
robrap approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@robrap robrap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I provided minor possible changes.

oeps/processes/oep-0055/decisions/0001-use-backstage-to-support-maintainers.rst Outdated Show resolved Hide resolved
oeps/processes/oep-0055/decisions/0001-use-backstage-to-support-maintainers.rst Outdated Show resolved Hide resolved
robrap
robrap reviewed Jul 5, 2024
View reviewed changes
Copy link
Contributor

@robrap robrap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, do we want to add a Change History section?

feanil
feanil reviewed Jul 15, 2024
View reviewed changes
Copy link
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion to take or leave. I like my version because it makes it clear that it sometimes makes sense to use other icons but mostly you should stick to "Web"

oeps/processes/oep-0055/decisions/0001-use-backstage-to-support-maintainers.rst Outdated Show resolved Hide resolved
@sarina
Copy link
Contributor Author

sarina commented Jul 15, 2024

@feanil I agree, your wording captures it well

@sarina
docs: catalog-info.yaml should primarily use "Web" for icon
6233785 
Co-authored-by: Robert Raposa <[email protected]>

Co-authored-by: Feanil Patel <[email protected]>
@sarina sarina merged commit f5b9e33 into master Jul 18, 2024
5 checks passed
@sarina sarina deleted the issue-568 branch July 18, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robrap robrap robrap approved these changes

@feanil feanil feanil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sarina @feanil @robrap