Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use react-router to properly handle basepaths for internal links #422

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

fix: use react-router to properly handle basepaths for internal links

a6dad89
Select commit
Loading
Failed to load commit list.
Open

fix: use react-router to properly handle basepaths for internal links #422

fix: use react-router to properly handle basepaths for internal links
a6dad89
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 1, 2023 in 1s

67.23% (+0.26%) compared to f3637b5

View this Pull Request on Codecov

67.23% (+0.26%) compared to f3637b5

Details

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (f3637b5) 66.96% compared to head (a6dad89) 67.23%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #422      +/-   ##
==========================================
+ Coverage   66.96%   67.23%   +0.26%     
==========================================
  Files          25       25              
  Lines         339      354      +15     
  Branches       78       84       +6     
==========================================
+ Hits          227      238      +11     
- Misses        110      113       +3     
- Partials        2        3       +1     
Files Coverage Δ
src/studio-header/utils.js 100.00% <ø> (ø)
src/studio-header/CourseLockUp.jsx 87.50% <80.00%> (-12.50%) ⬇️
src/studio-header/NavDropdownMenu.jsx 91.66% <88.88%> (-8.34%) ⬇️
src/studio-header/MobileMenu.jsx 81.81% <33.33%> (-18.19%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.