feat: Adding human readable 403 error access restricted #1569
Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @farhaanbukhsh! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
farhaanbukhsh
force-pushed
the
farhaan/adding-403-error
branch
from
4343567 to
3c103c9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1569 +/- ##
==========================================
+ Coverage 92.97% 92.99% +0.01%
==========================================
Files 1075 1078 +3
Lines 21205 21359 +154
Branches 4562 4616 +54
==========================================
+ Hits 19715 19862 +147
- Misses 1424 1425 +1
- Partials 66 72 +6 ☔ View full report in Codecov by Sentry. |
farhaanbukhsh
force-pushed
the
farhaan/adding-403-error
branch
2 times, most recently
from
0d905f9 to
bac3bee
Compare
|
@ChrisChV can you review this? |
farhaanbukhsh
force-pushed
the
farhaan/adding-403-error
branch
from
bac3bee to
b403144
Compare
|
Sure @farhaanbukhsh I will review it tomorrow |
farhaanbukhsh
force-pushed
the
farhaan/adding-403-error
branch
2 times, most recently
from
ff9c70b to
1ba6bb4
Compare
|
@ChrisChV I have fixed the comments and in addition to that I have fixed a typo that I encountered. |
| export const getErrorDetails = (error, dismissible = true) => { | ||
| const errorInfo = { dismissible }; | ||
| if (error.response?.status === 403) { | ||
| // For 403 status the error should be dismissible |
There was a problem hiding this comment.
| // For 403 status the error should be dismissible | |
| // For 403 status the error should not be dismissible |
There was a problem hiding this comment.
good catch :) fixed. Please merge it when the tests go green 😄
Signed-off-by: Farhaan Bukhsh <[email protected]>
Signed-off-by: Farhaan Bukhsh <[email protected]>
farhaanbukhsh
force-pushed
the
farhaan/adding-403-error
branch
from
1ba6bb4 to
4ccb21c
Compare
Description
Updated to have human readable forbidden error (403), this change came into picture from the discussion
on issue 361
Useful information to include:
New Alert
Supporting information
Discussion on issue 361
Testing instructions
tutor dev launchtutor mounts add < path to frontend-app-authoring>tutor images build openedx-devtutor dev stopfollowed bytutor dev start -dDeadline
"None" if there's no rush, or provide a specific date or event (and reason) if there is one.Other information
Private ref: BB-9399