Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updates group page to render more than 10 groups #1382

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

katrinan029
Copy link
Contributor

@katrinan029 katrinan029 commented Jan 14, 2025

Description

Updates the groups page to render more than 10 groups.

Screenshot 2025-01-14 at 1 49 07 PM

Testing instructions

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.83%. Comparing base (4b4924b) to head (596cb74).

Files with missing lines Patch % Lines
...it-management/data/hooks/useAllEnterpriseGroups.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1382      +/-   ##
==========================================
+ Coverage   85.80%   85.83%   +0.02%     
==========================================
  Files         624      624              
  Lines       13640    13635       -5     
  Branches     2855     2855              
==========================================
- Hits        11704    11703       -1     
+ Misses       1866     1862       -4     
  Partials       70       70              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@katrinan029 katrinan029 marked this pull request as ready for review January 14, 2025 21:40
@katrinan029 katrinan029 requested a review from a team January 14, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants