Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't show groups cards zero state while groups data is loading #1380

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

marlonkeating
Copy link
Contributor

Jira Ticket

This change adds a loading skeleton for the groups cards section while groups are loading.

Testing Instructions

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Jan 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.80%. Comparing base (825bc69) to head (f66821e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1380   +/-   ##
=======================================
  Coverage   85.80%   85.80%           
=======================================
  Files         625      625           
  Lines       13639    13642    +3     
  Branches     2814     2858   +44     
=======================================
+ Hits        11703    11706    +3     
  Misses       1866     1866           
  Partials       70       70           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marlonkeating marlonkeating merged commit 598996b into master Jan 14, 2025
6 checks passed
@marlonkeating marlonkeating deleted the mkeating/ENT-9851 branch January 14, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants