-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: altering bulk enrollment action behaviour #1081
Conversation
@@ -97,7 +97,7 @@ describe('<DeleteHighlightSet />', () => { | |||
expect(sendEnterpriseTrackEvent).toHaveBeenCalledTimes(1); | |||
}); | |||
|
|||
it('cancelling confirmation modal closes modal', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just trying to make sure we're using only the US spelling throughout the code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I never knew the double "l" was more used outside of the US! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See I have to catch myself because apparently I use british spelling for a lot of stuff accidentally? Like grey (which is gray in the US?)
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1081 +/- ##
==========================================
- Coverage 84.27% 84.25% -0.02%
==========================================
Files 463 463
Lines 9658 9656 -2
Branches 2003 2002 -1
==========================================
- Hits 8139 8136 -3
- Misses 1477 1478 +1
Partials 42 42
☔ View full report in Codecov by Sentry. |
@@ -97,7 +97,7 @@ describe('<DeleteHighlightSet />', () => { | |||
expect(sendEnterpriseTrackEvent).toHaveBeenCalledTimes(1); | |||
}); | |||
|
|||
it('cancelling confirmation modal closes modal', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I never knew the double "l" was more used outside of the US! :)
src/components/learner-credit-management/AssignmentRowActionTableCell.jsx
Outdated
Show resolved
Hide resolved
src/components/learner-credit-management/AssignmentRowActionTableCell.jsx
Outdated
Show resolved
Hide resolved
src/components/learner-credit-management/AssignmentRowActionTableCell.jsx
Outdated
Show resolved
Hide resolved
src/components/learner-credit-management/AssignmentRowActionTableCell.jsx
Outdated
Show resolved
Hide resolved
src/components/learner-credit-management/AssignmentRowActionTableCell.jsx
Outdated
Show resolved
Hide resolved
src/components/learner-credit-management/tests/BudgetDetailPage.test.jsx
Outdated
Show resolved
Hide resolved
src/components/learner-credit-management/tests/BudgetDetailPage.test.jsx
Outdated
Show resolved
Hide resolved
src/components/learner-credit-management/tests/BudgetDetailPage.test.jsx
Outdated
Show resolved
Hide resolved
src/components/learner-credit-management/tests/BudgetDetailPage.test.jsx
Outdated
Show resolved
Hide resolved
src/components/learner-credit-management/AssignmentRowActionTableCell.jsx
Outdated
Show resolved
Hide resolved
src/components/learner-credit-management/AssignmentRowActionTableCell.jsx
Outdated
Show resolved
Hide resolved
…min-portal into kiram15/ENT-7923
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but with some minor comments likely worth addressing first.
Jira ticket with context here
Continuation of this PR
Clip with new bulk action recording (remind is only valid with "waiting for learner" status, and is disabled if the count of the rows selected is 0)
https://github.com/openedx/frontend-app-admin-portal/assets/31229189/d7114dfd-26ab-48fe-b575-dc4ed4289759
For all changes
Only if submitting a visual change