Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: altering bulk enrollment action behaviour #1081

Merged
merged 6 commits into from
Nov 6, 2023
Merged

Conversation

kiram15
Copy link
Contributor

@kiram15 kiram15 commented Nov 2, 2023

Jira ticket with context here

Continuation of this PR

Clip with new bulk action recording (remind is only valid with "waiting for learner" status, and is disabled if the count of the rows selected is 0)
https://github.com/openedx/frontend-app-admin-portal/assets/31229189/d7114dfd-26ab-48fe-b575-dc4ed4289759

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@kiram15 kiram15 requested review from adamstankiewicz and a team November 2, 2023 20:29
@@ -97,7 +97,7 @@ describe('<DeleteHighlightSet />', () => {
expect(sendEnterpriseTrackEvent).toHaveBeenCalledTimes(1);
});

it('cancelling confirmation modal closes modal', () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just trying to make sure we're using only the US spelling throughout the code

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I never knew the double "l" was more used outside of the US! :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See I have to catch myself because apparently I use british spelling for a lot of stuff accidentally? Like grey (which is gray in the US?)

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (e97f7ae) 84.27% compared to head (1fbcc0b) 84.25%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1081      +/-   ##
==========================================
- Coverage   84.27%   84.25%   -0.02%     
==========================================
  Files         463      463              
  Lines        9658     9656       -2     
  Branches     2003     2002       -1     
==========================================
- Hits         8139     8136       -3     
- Misses       1477     1478       +1     
  Partials       42       42              
Files Coverage Δ
...gs/SettingsSSOTab/steps/SSOConfigConfigureStep.jsx 94.73% <ø> (ø)
src/data/services/EnterpriseAccessApiService.js 79.31% <ø> (ø)
...credit-management/AssignmentRowActionTableCell.jsx 77.77% <80.00%> (+2.77%) ⬆️
...earner-credit-management/AssignmentTableRemind.jsx 83.33% <50.00%> (-5.56%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -97,7 +97,7 @@ describe('<DeleteHighlightSet />', () => {
expect(sendEnterpriseTrackEvent).toHaveBeenCalledTimes(1);
});

it('cancelling confirmation modal closes modal', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I never knew the double "l" was more used outside of the US! :)

Copy link
Member

@adamstankiewicz adamstankiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but with some minor comments likely worth addressing first.

@kiram15 kiram15 merged commit bb42b60 into master Nov 6, 2023
3 of 5 checks passed
@kiram15 kiram15 deleted the kiram15/ENT-7923 branch November 6, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants