Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error when trying to save 'other education' #881

Conversation

Inferato
Copy link

When user selects "Other Education" and clicks save - error occurs.

It's caused by the wrong API call payload value 'o'
Fix: use the 'other' payload value instead (the valid one).

@openedx-webhooks
Copy link

Thanks for the pull request, @Inferato! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 20, 2023
@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 2, 2023
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

All modified lines are covered by tests ✅

❗ No coverage uploaded for pull request base (open-release/palm.master@03e3b67). Click here to learn what that means.

Additional details and impacted files
@@                     Coverage Diff                     @@
##             open-release/palm.master     #881   +/-   ##
===========================================================
  Coverage                            ?   38.63%           
===========================================================
  Files                               ?      110           
  Lines                               ?     2288           
  Branches                            ?      624           
===========================================================
  Hits                                ?      884           
  Misses                              ?     1319           
  Partials                            ?       85           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 10, 2023
@mphilbrick211
Copy link

Hi @openedx/fed-bom! Would someone be able to review/merge this for us? Thanks!

@mphilbrick211
Copy link

Hi @abdullahwaheed! Are you able to get this merged for us?

@abdullahwaheed abdullahwaheed merged commit 9e338d0 into openedx:open-release/palm.master Oct 19, 2023
@openedx-webhooks
Copy link

@Inferato 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants