fix: pass course run keys as strings, not CourseLocator #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When passing a CourseLocator, fetching the content metadata from Discovery fails because the requests library cannot handle non-string or other non-primitive values as query parameters. This must have gotten past local devstack testing because the value was already cached via TieredCache, thus bypassing the code that actually calls the Discovery API. ENT-9885
pwnage101
force-pushed
the
pwnage101/ENT-9885-4
branch
from
c1f2281 to
3312122
Compare
iloveagent57
approved these changes
Jan 9, 2025
adamstankiewicz
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When passing a CourseLocator to
ContentMetadataApi.get_content_metadata, fetching the content metadata from Discovery fails because the requests library cannot handle non-string or other non-primitive values as query parameters. This must have gotten past local devstack testing because the value was already cached via TieredCache, thus bypassing the code that actually calls the Discovery API.ENT-9885