Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduce cache timeout for licenses and enrollments #608

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

adamstankiewicz
Copy link
Member

@adamstankiewicz adamstankiewicz commented Dec 4, 2024

Description:

  1. Sets the ENTERPRISE_COURSE_ENROLLMENTS_CACHE_TIMEOUT to 0, to effectively disable caching on the enterprise_course_enrollments API. Rationale: enrollments data may mutate frequently (e.g., new enrollments, unenrollment, email settings change, moving enrollment from in-progress to saved for later on the Learner Portal dashboard.
  2. Reduces the SUBSCRIPTION_LICENSES_LEARNER_CACHE_TIMEOUT to 1 minute instead of 2 for more frequent cache busting (e.g., for admin revokes, etc.).
  3. Note: a separate PR against edx-internal will be opened to reduce the cache timeouts in stage for more frequent cache bustings during QA/debugging.

Merge checklist:

  • ./manage.py makemigrations has been run
    • Note: This must be run if you modified any models.
      • It may or may not make a migration depending on exactly what you modified, but it should still be run.

Post merge:

  • Ensure that your changes went out to the stage instance
  • Deploy to prod instance

@adamstankiewicz adamstankiewicz marked this pull request as ready for review December 4, 2024 17:02
@adamstankiewicz adamstankiewicz merged commit ec0bef8 into main Dec 4, 2024
3 checks passed
@adamstankiewicz adamstankiewicz deleted the ags/enrollments-cache-timeout-bff branch December 4, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants