Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: account for revoked licenses and staff users in auto-apply logic #605

Merged
merged 3 commits into from
Dec 2, 2024

Conversation

adamstankiewicz
Copy link
Member

@adamstankiewicz adamstankiewicz commented Dec 2, 2024

Description:

Extends auto-apply subscription license business logic and tests to include:

  • Check for revoked subscription licenses (i.e., no auto-apply with revoked license).
  • Check for being explicitly linked to the requested enterprise customer (i.e., no auto-apply as an unlinked staff user).

These additional checks ensure parity with existing business logic around auto-applied subscription licenses in the frontend (source).

Jira:
ENT-9813

Merge checklist:

  • ./manage.py makemigrations has been run
    • Note: This must be run if you modified any models.
      • It may or may not make a migration depending on exactly what you modified, but it should still be run.

Post merge:

  • Ensure that your changes went out to the stage instance
  • Deploy to prod instance

@adamstankiewicz adamstankiewicz marked this pull request as ready for review December 2, 2024 17:07
Copy link
Contributor

@iloveagent57 iloveagent57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small suggestions, looks good otherwise!

enterprise_access/apps/api/v1/tests/test_bff_views.py Outdated Show resolved Hide resolved
enterprise_access/apps/bffs/handlers.py Outdated Show resolved Hide resolved
@adamstankiewicz adamstankiewicz force-pushed the ags/auto-apply-subs-checks branch from 23650d3 to f1d0060 Compare December 2, 2024 20:39
@adamstankiewicz adamstankiewicz merged commit 24873c3 into main Dec 2, 2024
3 checks passed
@adamstankiewicz adamstankiewicz deleted the ags/auto-apply-subs-checks branch December 2, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants