build: Log in to dockerhub for unit test CI #36089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're being rate limited by dockerhub for pulling too many images in CI. There isn't a greate solution for caching images for GH actions, but in theory we should have less strict limits as an authenticated user.
timmc-edx
approved these changes
Jan 9, 2025
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
kdmccormick
added a commit
to kdmccormick/edx-platform
that referenced
this pull request
Jan 10, 2025
Iterating on openedx#36089 Forks will fail to log into DockerHub unless the fork owner configured their own DockerHub creds. This PR is an attempt to make it so that unit tests don't fail when DockerHub login fails.
This was referenced Jan 10, 2025
kdmccormick
added a commit
that referenced
this pull request
Jan 10, 2025
This iterates on #36089, which logged us into DockerHub during unit tests in order to reduce how often DockerHub rate-limits us. Forks will fail to log into DockerHub unless the fork owner configures their own DockerHub creds. This PR is an attempt to make it so that unit tests don't fail when DockerHub login fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We're being rate limited by dockerhub for pulling too many images in CI. There isn't a greate solution for caching images for GH actions, but in theory we should have less strict limits as an authenticated user.
Supporting information
See: openedx/axim-engineering#1350 and https://github.com/openedx/edx-platform/actions/runs/12679554529/job/35339477364