Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update code owner details #263

Merged
merged 1 commit into from
Feb 27, 2024
Merged

chore: update code owner details #263

merged 1 commit into from
Feb 27, 2024

Conversation

zainab-amir
Copy link
Contributor

@zainab-amir zainab-amir commented Feb 26, 2024 •
edited
Loading

Description: Updates code owner info from 2u-vanguards to 2u-infinity

JIRA: https://2u-internal.atlassian.net/browse/VAN-1857

Reviewers:

  • tag reviewer @feanil
  • tag reviewer @openedx/2u-infinity

Merge checklist:

  • All reviewers approved
  • CI build is green

@zainab-amir zainab-amir requested a review from feanil February 26, 2024 09:56
@zainab-amir zainab-amir mentioned this pull request Feb 26, 2024
Closed
@zainab-amir
Copy link
Contributor Author

Unable to add @openedx/2u-infinity as reviewers to this PR. Related issue created for axim openedx/axim-engineering#1065

hurtstotouchfire
hurtstotouchfire reviewed Feb 26, 2024
View reviewed changes
catalog-info.yaml Outdated
@@ -13,6 +13,6 @@ metadata:
annotations:
openedx.org/arch-interest-groups: ""
spec:
owner: group:vanguards
owner: group:edx-infinity
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought that we changed all these legacy group names to 2u-something but Asad can fix it if this is wrong.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, this should be 2u-infinity and if that team does not have the right people on it, we can update but it should be the team used moving forward.

@arbrandes arbrandes requested a review from a team February 26, 2024 16:05
@arbrandes
Copy link
Contributor

I added the 2u-infinity team to this repository with explicit write permissions, after which it became possible to add it as a reviewer.

feanil
feanil requested changes Feb 26, 2024
View reviewed changes
catalog-info.yaml Outdated
@@ -13,6 +13,6 @@ metadata:
annotations:
openedx.org/arch-interest-groups: ""
spec:
owner: group:vanguards
owner: group:edx-infinity
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, this should be 2u-infinity and if that team does not have the right people on it, we can update but it should be the team used moving forward.

@zainab-amir zainab-amir force-pushed the zamir/update_code_owners_info branch from e420def to e8c9568 Compare February 27, 2024 05:18
@zainab-amir zainab-amir requested a review from feanil February 27, 2024 05:19
@asadazam93
Copy link

@feanil can you make me (asadazam93) the maintainer of https://github.com/orgs/openedx/teams/2u-infinity? The team members are not up to date

@zainab-amir zainab-amir merged commit 2344cce into master Feb 27, 2024
8 checks passed
@zainab-amir zainab-amir deleted the zamir/update_code_owners_info branch February 27, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hurtstotouchfire hurtstotouchfire hurtstotouchfire approved these changes

@asadazam93 asadazam93 asadazam93 approved these changes

@feanil feanil feanil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zainab-amir @arbrandes @asadazam93 @feanil @hurtstotouchfire