perf: relegate optgroup calculation to superclass #4540
Conversation
|
The super code is somewhat different. It does some mangling around of Edit: In particular, the superclass restricts the |
| def test_optgroups_are_sorted(self, value, result_order): | ||
| choices = ((1, 'one'), (2, 'two'), (3, 'three')) | ||
| widget = SortedModelSelect2Multiple(url='requiredurl', choices=choices) | ||
| result = widget.optgroups('test', value) |
There was a problem hiding this comment.
It is hard to do a simple optgroups test like this now since the method calls the super method, which expects things to be set up much more properly. e.g requiring self.choices to have a queryset attribute, having the url kwarg of the widget being an actual reversible url etc.
I have added a new test in place, which renders the program admin form, and ensures that the courses are rendered in the order in which they were assigned. I am unsure if this test is more appropriate in test_admin.py now.
PROD-4274
Description
4538 seems to have improved the perf by about 45% (on stage) which is lesser than what I expected.
Refactor
SortedModelSelect2Multiple.optgroupsto call the superclassoptgroupsto retrieve the options and then sort them accordingly. This is an attempt at further improving the performance. A side effect is that it simplifies the code.