Skip to content

Commit

Permalink
feat: match best practices from browserslist (#16)
Browse files Browse the repository at this point in the history
* feat: match best practices from browserslist docs
* fix: update to ensure IE11 is excluded
* chore: bump version in anticipation of release
  • Loading branch information
bradenmacdonald authored Dec 9, 2024
1 parent e3e0b5c commit 42abbdb
Show file tree
Hide file tree
Showing 3 changed files with 67 additions and 24 deletions.
14 changes: 12 additions & 2 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,16 @@ const mobile = [
'last 3 iOS major versions',
];

const supportedBrowsers = desktop.concat(mobile);
// Other browsers are not officially supported by Open edX, but
// adding these is strongly recommended by browserslist, so we do so:
// https://github.com/browserslist/browserslist?tab=readme-ov-file#best-practices
const bestPractices = [
'last 2 versions and not dead',
'> 0.2% and not dead',
];

module.exports = supportedBrowsers;
module.exports = [
...desktop,
...mobile,
...bestPractices,
];
73 changes: 53 additions & 20 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@edx/browserslist-config",
"version": "1.0.0",
"version": "1.3.0",
"description": "Shared browserslist config for Open edX",
"repository": {
"type": "git",
Expand All @@ -23,6 +23,6 @@
"supported": "node -e \"var bl = require('browserslist'); console.log(bl(require('./index')).join('\\n'));\""
},
"devDependencies": {
"browserslist": "4.20.3"
"browserslist": "4.24.2"
}
}

0 comments on commit 42abbdb

Please sign in to comment.