Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add squad field to onboarding form #963

Merged
merged 1 commit into from
Nov 6, 2023
Merged

docs: Add squad field to onboarding form #963

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/ISSUE_TEMPLATE/01-github-request---onboarding.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,11 @@ body:
* ...
validations:
required: true
- type: input
id: squad
attributes:
label: User Squad
description: If the users specified above are members of a named squad or team at your firm, optionally specify it here. This will help simplify access management in the future.
Copy link
Contributor Author

@arbrandes arbrandes Nov 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make the distinction between squad and Github team? Does it matter if folks put in a Github team?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know - probably a question for Ned

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH, i don't know what information the 2U help desk will have when they fill this out. This seems like a fine description to start with.

- type: input
id: start-date
attributes:
Expand All @@ -49,7 +54,7 @@ body:
id: requests
attributes:
label: Special Requests
description: For now, all new 2U/edX employees will be granted access to `push-pull-all`. If these users need to be added to any specific teams or given any elevated privileges, note them here.
description: For now, all new 2U/edX employees will be granted access to `2u-edx-legacy`. If these users need to be added to any specific Github teams or given any elevated privileges, note them here.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we weren't adding new people to 2u-edx-legacy? I know there are newer engineers who are not in the team.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, maybe that was just a hiccup? It looks like even newer people are in the team.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I understand it, we're still supposed to add people to it if requested. What's fuzzy to me is if it's not requested.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing we can deal with the wording here separately, so going ahead and merging the PR.

- type: markdown
attributes:
value: "## Once you create this request, the Axim engineering team will triage it and handle it as appropriate. If your request is especially urgent, please note that above!"