fix in-app purchases

opendocument-app · May 30, 2020 · 574c847 · 574c847
1 parent a03779b
commit 574c847
Show file tree

Hide file tree

Showing 4 changed files with 29 additions and 6 deletions.
diff --git a/OpenDocument.core b/OpenDocument.core
diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml
@@ -3,8 +3,8 @@
         xmlns:tools="http://schemas.android.com/tools"
         package="at.tomtasche.reader"
         android:installLocation="auto"
-        android:versionCode="131"
-        android:versionName="3.3.1"
+        android:versionCode="132"
+        android:versionName="3.3.2"
         tools:ignore="GoogleAppIndexingWarning">
 
     <uses-permission

diff --git a/app/src/main/java/at/tomtasche/reader/background/BillingPreferences.java b/app/src/main/java/at/tomtasche/reader/background/BillingPreferences.java
@@ -18,7 +18,7 @@ public boolean hasPurchased() {
             return false;
         }
 
-        return sharedPreferences.getBoolean("purchased", false);
+        return sharedPreferences.getBoolean("purchaseAcknowledged", false);
     }
 
     public void setPurchased(boolean purchased) {
@@ -27,7 +27,7 @@ public void setPurchased(boolean purchased) {
         }
 
         Editor editor = sharedPreferences.edit();
-        editor.putBoolean("purchased", purchased);
+        editor.putBoolean("purchaseAcknowledged", purchased);
         editor.apply();
     }
 }
diff --git a/app/src/main/java/at/tomtasche/reader/nonfree/BillingManager.java b/app/src/main/java/at/tomtasche/reader/nonfree/BillingManager.java
@@ -2,6 +2,8 @@
 
 import android.content.Context;
 
+import com.android.billingclient.api.AcknowledgePurchaseParams;
+import com.android.billingclient.api.AcknowledgePurchaseResponseListener;
 import com.android.billingclient.api.BillingClient;
 import com.android.billingclient.api.BillingClientStateListener;
 import com.android.billingclient.api.BillingFlowParams;
@@ -118,8 +120,29 @@ private void refreshPurchased() {
             return;
         }
 
+        boolean hasPurchased = false;
+
         Purchase.PurchasesResult purchasesResult = billingClient.queryPurchases(BillingClient.SkuType.INAPP);
-        boolean hasPurchased = purchasesResult != null && purchasesResult.getPurchasesList() != null && !purchasesResult.getPurchasesList().isEmpty();
+        if (purchasesResult.getPurchasesList() != null) {
+            for (Purchase purchase : purchasesResult.getPurchasesList()) {
+                if (!purchase.isAcknowledged()) {
+                    AcknowledgePurchaseParams.Builder builder = AcknowledgePurchaseParams.newBuilder();
+                    builder.setPurchaseToken(purchase.getPurchaseToken());
+
+                    billingClient.acknowledgePurchase(builder.build(), new AcknowledgePurchaseResponseListener() {
+                        @Override
+                        public void onAcknowledgePurchaseResponse(BillingResult billingResult) {
+                            // TODO: in the best case we would set hasPurchased to true only now. not worth the effort in my opinion
+                        }
+                    });
+                }
+
+                hasPurchased = true;
+
+                break;
+            }
+        }
+
         billingPreferences.setPurchased(hasPurchased);
     }