Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Add builder constructor that takes algo params #292

Conversation

jmazanec15
Copy link
Member

Issue #, if available:
#288

Description of changes:
Backport mapper merge fix to odfe-1.12

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jmazanec15 jmazanec15 added the Bug Fixes Change that fixes a bug label Dec 30, 2020
@jmazanec15 jmazanec15 changed the title Add builder constructor that takes algo params (#289) Add builder constructor that takes algo params Dec 30, 2020
@codecov
Copy link

codecov bot commented Dec 30, 2020

Codecov Report

❗ No coverage uploaded for pull request base (opendistro-1.12@de2019a). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                 @@
##             opendistro-1.12     #292   +/-   ##
==================================================
  Coverage                   ?   79.49%           
  Complexity                 ?      359           
==================================================
  Files                      ?       58           
  Lines                      ?     1414           
  Branches                   ?      129           
==================================================
  Hits                       ?     1124           
  Misses                     ?      242           
  Partials                   ?       48           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de2019a...fafb66f. Read the comment docs.

Copy link
Member

@vamshin vamshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jmazanec15 jmazanec15 merged commit fbf9566 into opendistro-for-elasticsearch:opendistro-1.12 Dec 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Fixes Change that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants