This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Add builder constructor that takes algo params #289
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#288
Description of changes:
In this PR, I added a constructor for KNNVectorFieldMapper.Builder that takes the algorithm parameters that it typically reads from settings. This constructor is used during merging of mappers. It allows an existing KNNVectorFieldMapper to pass settings to a KNNVectorFieldMapper.Builder for merge. It plays a similar role to the
ParametrizedFieldMapper.init
method, which copies mapping parameters from an already existing FieldMapper to the FieldMapper.Builder that will be used for merging. I decided to not override this method because it is more focused on mapping parameters, but I am open to feedback on this.Verified that with this change, I am unable to reproduce the issue following the steps in #288.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.