Allow override of dataset badges #3189
Conversation
|
This fix has been deployed in production to fix saving SPD datasets. |
|
Sure thing @maudetes! |
| class DatasetBadge(Badge): | ||
| kind = db.StringField(required=True, choices=list(BADGES.keys())) | ||
| kind = db.StringField(required=True, validation=validate_badge) |
There was a problem hiding this comment.
using choices makes it use a dropdown in swagger, which is convenient, but I don't know any existing way to have a dynamic list of choices... so I guess we have to let go of that convenience ;)
There was a problem hiding this comment.
I've actually tried keeping choices with a lambda to compute the value dynamically but I could not make it work sadely
There was a problem hiding this comment.
Yep, I tried also in the past, and couldn't make it work. There doesn't seem to be a way to do it, other than hacking/monkeypatching the lib itself, which seemed a little bit too much at the time.
I'll have a deeper look in the future if it's prioritized 👍
|
If we keep this direction, we may want to apply the same logic to other badges type |
Follows up on #3189, fixes [#1564](datagouv/data.gouv.fr#1564) --------- Co-authored-by: maudetes <[email protected]>
Fix datagouv/data.gouv.fr#1564
This is a quickfix for the dataset case, we may want to find a cleaner solution that apply to all.