Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support csw dcat harvest #2800
Support csw dcat harvest #2800
Changes from 17 commits
8e28bd7
c1d6f50
89079e1
3633007
9cc93ad
7156205
be50028
0dbfc2d
02b5624
0f2bf14
f0e736c
7617e66
dcac080
7b60d7f
ef27113
23ab5c3
382772a
496ee8c
e573378
e324779
70dd0b3
966c2e9
74ff3e3
3a7992f
f3c8793
b1f2d86
7b48b8e
b409af8
26cbbfc
8d9539f
f2fa89a
d1117ee
dd98a8b
f44c56e
29e3021
e9fd92b
7be2386
8ebe100
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would be the best between making a POST using our crafted body or expecting a complete url to make a GET query on it?
I would say a
POST
with our body would make it easier on the user side, but it may prevent the user from adding custom params to the targeted endpoint.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CSW spec allows GET and/or POST and this is advertised in the GetCapabilities
but most implementations probably support both.
documentStandard
is quite specific to GeoNetwork and in this case related to the fact that we want to only request metadata records which are in a standard which provides a mapping to DCAT (currently ISO19139 and ISO19115-3) and avoid failures on catalogues containing records on other standards (eg. Dublin core or ISO19110). No criteria is needed if the target catalogue contains only ISO19139.You can probably increase page size - we have been using 200 records per page for INSPIRE member states harvesting with no issue.
Can be good to add a sort by clause to avoid potential issue of records appearing in various pages if index changes occur during harvesting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About
documentStandard
filter, you should probably remove it from your side and ask GeoNetwork users to set up a dedicated portal on their catalogue in order to filter on their side the records they want to be harvested (so they can filter ondocumentStandard
if they have metadata records not supporting mapping to DCAT - which should not happen often).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the inputs!
documentStandard
, we should probably add a mention about the need to expose a catalog with records that support mapping to DCAT in our documentation also!