Add FreeBSD support

[mateuszkwiatkowski]

This PR add support for building umoci on FreeBSD.

Ref. #330

[cyphar]

You need to add a Signed-off-by: line to your commit(s) which indicates that you attest the Developer Certificate of Origin a statement about your contributions that you must read before signing (don't worry, it's quite short and easy-to-read). You can add it to your commits with git commit --amend -s, and then doing a git push --force.

NOTE: This is a saved reply. Sorry if it reads as a cookie-cutter response, it was written so that newcomers understand what a "DCO" is and make the process for contributing a little less scary.

[mateuszkwiatkowski]

@cyphar thank you for a tip. It should be fine now.

[mateuszkwiatkowski]

Hey @cyphar,
Did you have a chance to take a look? Is it good direction to introduce FreeBSD support? I’ll be happy to work further on this, I just need your feedback. 👨🏻‍🔧

[mateuszkwiatkowski]

@cyphar friendly reminder about this PR. :-)

[cyphar]

A couple of issues with types and a minor cleanup to avoid duplicating Tarmode.

[mateuszkwiatkowski]

@cyphar thank you for your patience. I addressed your feedback again.

[cyphar]

If you can just squish your last three commits into one (so that the mknod changes are all in one commit), and CI passes this should be a good to go. Thanks! :D

[mateuszkwiatkowski]

@cyphar squashed and force-pushed!

[mateuszkwiatkowski]

One more commit incomming to fix failed test.

[mateuszkwiatkowski]

Ok, this one surprised me:

docker run --rm -v /home/travis/gopath/src/github.com/opencontainers/umoci:/go/src/github.com/opencontainers/umoci --security-opt apparmor=unconfined --security-opt label=disable --security-opt seccomp=unconfined --security-opt systempaths=unconfined  -e CODECOV_ENV -e CODECOV_TOKEN -e CODECOV_URL -e CODECOV_SLUG -e VCS_COMMIT_ID -e VCS_BRANCH_NAME -e VCS_PULL_REQUEST -e VCS_SLUG -e VCS_TAG -e CI_BUILD_URL -e CI_BUILD_ID -e CI_JOB_ID -e CI -e TRAVIS -e SHIPPABLE -e TRAVIS_BRANCH -e TRAVIS_COMMIT -e TRAVIS_JOB_NUMBER -e TRAVIS_PULL_REQUEST -e TRAVIS_JOB_ID -e TRAVIS_REPO_SLUG -e TRAVIS_TAG -e TRAVIS_OS_NAME  --privileged --cap-add=SYS_ADMIN -e COVERAGE -e TESTS umoci/ci:latest make local-test-integration
623TESTS="" hack/test-integration.sh
624make: which: Command not found

I think it's from SHELL := $(shell which bash) in Makefile.
I'll try to figure out a bit later.

Edit: This docker run worked for me locally.

[mateuszkwiatkowski]

Hi @cyphar,

Few more fixes and CI is happy. Changes:

• mknod_linux.go to mknod_unix.go to fix build on Darwin
• Tarmode() deserved separate file to avoid duplication
• added which package to fix make in Docker

[cyphar]

LGTM. I will look at adding a CI check to make sure we don't use unix.Mknod by accident (as well as adding FreeBSD to our CI checks) -- thanks for the PR!

[cyphar]

/cc @tych0

[mateuszkwiatkowski]

@cyphar thank you for your time. Is lack of that test a blocker for this PR or can we have it merged and add that test later?
Regarding the CI platform, I think that https://cirrus-ci.org is preferred by some FreeBSD native projects.

[cyphar]

No, it's not a blocker. I'm waiting for @tych0 to review this since we need two LGTMs.

[mateuszkwiatkowski]

FYI: I've just created and pushed freebsd image to Docker Hub: https://hub.docker.com/r/kwiat/freebsd/tags

[tych0]

LGTM.

[mateuszkwiatkowski]

@cyphar @tych0 could you please merge this PR? I have a port for FreeBSD Ports ready for submission but it requires that the change is in master and new release is tagged. Thank you in advance.

[cyphar]

Yup, I think Tycho forgot to hit the merge button.

[mateuszkwiatkowski]

@cyphar woohoo! thank you for cooperation and your assistance. :-)