Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ingress policer to qos overview #1190

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

dplore
Copy link
Member

@dplore dplore commented Sep 24, 2024

Adding documentation on how to use the /qos model to create an ingress policer

@dplore dplore requested a review from a team as a code owner September 24, 2024 20:09
@OpenConfigBot
Copy link

OpenConfigBot commented Sep 24, 2024

No major YANG version changes in commit 3f91434

doc/qos_overview.md Outdated Show resolved Hide resolved
doc/qos_overview.md Outdated Show resolved Hide resolved
doc/qos_overview.md Outdated Show resolved Hide resolved
doc/qos_overview.md Outdated Show resolved Hide resolved
doc/qos_overview.md Show resolved Hide resolved
@dplore dplore requested a review from robshakir October 2, 2024 22:46
@dplore
Copy link
Member Author

dplore commented Oct 2, 2024

@robshakir ready for your re-review

@LimeHat
Copy link

LimeHat commented Oct 3, 2024

I don't think this is the appropriate way to describe a canonical ingress policer.

While the scheduling typically supports rate-limiting mechanisms, in many implementations, there are separate policer entities (often implemented in HW) that are independent of schedulers; i.e., those are two different mechanisms.

The fake queuing/ingress scheduling approach feels more like a workaround for implementations where true ingress policers are not available (or they never implement "real" ingress scheduling and can perform this config translation into policing in native yang/cli model).
IMO it is fine if you want to describe that use case here, but stating that this is the (only) canonical way severely limits the range of covered scenarios and use cases.

In my view, the clearer approach is to introduce a new hierarchy to be used specifically to define standalone policers (e.g. /qos/policer-policies). This avoids any ambiguity w.r.t fake ingress queuing and allows for better extensibility.

@dplore
Copy link
Member Author

dplore commented Oct 8, 2024

@robshakir Ready for your next review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

5 participants