IEEE 802.1AG CFM connectivity management + ITU Y1731 Performance management #1182

AnnamalaiRajeev · 2024-09-17T16:15:57Z

Change Scope

802.1AG CFM + Y1731 Performance Management profiles are being added.
Backward compatibility: True

Platform Implementations

// Vendor 1 CiscoXR:

// Vendor 2 Juniper:
https://www.juniper.net/documentation/us/en/software/junos/network-mgmt/topics/topic-map/cfm-configuring.html

// Vendor 3 Nokia:

https://infocenter.nokia.com/public/7705SAR234R1A/index.jsp?topic=%2Fcom.nokia.oam-guide%2Fitu-t_y-1731_pe-ai9o99jjwe.html

[Note: Please provide at least two references to implementations which are relevant to the model changes proposed. Each implementation should be from separate organizations.].

// references

IEEE - https://ieeexplore.ieee.org/document/4431836.
Metro Ethernet Forum - https://github.com/MEF-GIT/YANG-public
MEF yang - https://github.com/MEF-GIT/YANG-public/tree/master/src/model/standard

[Note: If the feature being proposed is new - and something that is being
proposed as an enhancement to device functionality, it is sufficient to have
reviewers from the producers of two different implementations].

google-cla · 2024-09-17T16:16:02Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

* Adds references to the following leaf nodes [1] "remote-mep-id" [2] "mac-address" [2] "direction" * Updates description to "maintenance-domain" and adds a reference. * Adds leaf "group-name" to support Ciscoxr vendor implementation of xconnect/bridgedomains to support Ciscoxr implementation * https://github.com/YangModels/yang/blob/main/vendor/cisco/xr/613/Cisco-IOS-XR-ethernet-cfm-cfg.yang#L776C22-L776C33 * Adds "routing-disable" action to support Arista's implementation of link loss forwarding. * Merges ETH-SLM and ETH-LM into loss-measurement config and state. * Creates a common performance-measurement container for all performance-measurement functions i.e. delay & loss. * Moves "loss-measurement" and "delay-measurement" configs and states into a common performance-measurement container. * Moves the previously modeled loss measurement and delay measurement states into a "pm-profiles" container • Adds leaf-ref for "policy-name" associated with the endpoint to refer to the global policy

AnnamalaiRajeev · 2024-09-18T14:12:17Z

// Tree view - Commit 4

anamalai@gokussg:~$ path/to/venv/bin/pyang -f tree -p /google/src/cloud/anamalai/yang_p/google3/third_party/openconfig/public/release/models/ /google/src/cloud/anamalai/yang_p/google3/third_party/openconfig/public/release/models/cfm/openconfig-cfm.yang
module: openconfig-cfm
  +--rw cfm
     +--rw domains
     |  +--rw maintenance-domain* [md-id]
     |     +--rw md-id                       -> ../config/md-id
     |     +--rw config
     |     |  +--rw md-id?           oc-cfm-types:name-key-type
     |     |  +--rw level?           uint8
     |     |  +--rw md-name-type?    enumeration
     |     |  +--rw none?            boolean
     |     |  +--rw dns_like_name?   string
     |     |  +--rw address          oc-yang:mac-address
     |     |  +--rw unsigned-int     uint16
     |     |  +--rw char-string?     string
     |     +--ro state
     |     |  +--ro md-id?           oc-cfm-types:name-key-type
     |     |  +--ro level?           uint8
     |     |  +--ro md-name-type?    enumeration
     |     |  +--ro none?            boolean
     |     |  +--ro dns_like_name?   string
     |     |  +--ro address          oc-yang:mac-address
     |     |  +--ro unsigned-int     uint16
     |     |  +--ro char-string?     string
     |     +--rw maintenance-associations
     |        +--rw maintenance-association* [ma-id]
     |           +--rw ma-id            -> ../config/ma-id
     |           +--rw config
     |           |  +--rw ma-id?            oc-cfm-types:name-key-type
     |           |  +--rw group-name?       string
     |           |  +--rw ma-name-type?     enumeration
     |           |  +--rw primary-vid       oc-vlan-types:vlan-id
     |           |  +--rw char-string       string
     |           |  +--rw unsigned-int16    uint16
     |           |  +--rw vpn-oui           uint32
     |           |  +--rw vpn-index         uint32
     |           |  +--rw ccm-interval?     enumeration
     |           |  +--rw loss-threshold?   uint16
     |           +--ro state
     |           |  +--ro ma-id?            oc-cfm-types:name-key-type
     |           |  +--ro group-name?       string
     |           |  +--ro ma-name-type?     enumeration
     |           |  +--ro primary-vid       oc-vlan-types:vlan-id
     |           |  +--ro char-string       string
     |           |  +--ro unsigned-int16    uint16
     |           |  +--ro vpn-oui           uint32
     |           |  +--ro vpn-index         uint32
     |           |  +--ro ccm-interval?     enumeration
     |           |  +--ro loss-threshold?   uint16
     |           +--rw mep-endpoints
     |              +--rw mep-endpoint* [local-mep-id]
     |                 +--rw local-mep-id            -> ../config/local-mep-id
     |                 +--rw config
     |                 |  +--rw ccm-enabled?                           boolean
     |                 |  +--rw lowest-priority-defect?                oc-cfm-types:lowest-alarm-priority-type
     |                 |  +--rw fng-alarm-time?                        uint16
     |                 |  +--rw fng-reset-time?                        uint16
     |                 |  +--rw local-mep-id?                          oc-cfm-types:mep-id-type
     |                 |  +--rw interface?                             -> /oc-if:interfaces/interface/name
     |                 |  +--rw include-mep-port-status-in-tlv?        boolean
     |                 |  +--rw include-mep-interface-status-in-tlv?   boolean
     |                 |  +--rw direction?                             enumeration
     |                 +--ro state
     |                 |  +--ro ccm-enabled?                           boolean
     |                 |  +--ro lowest-priority-defect?                oc-cfm-types:lowest-alarm-priority-type
     |                 |  +--ro fng-alarm-time?                        uint16
     |                 |  +--ro fng-reset-time?                        uint16
     |                 |  +--ro local-mep-id?                          oc-cfm-types:mep-id-type
     |                 |  +--ro interface?                             -> /oc-if:interfaces/interface/name
     |                 |  +--ro include-mep-port-status-in-tlv?        boolean
     |                 |  +--ro include-mep-interface-status-in-tlv?   boolean
     |                 |  +--ro direction?                             enumeration
     |                 |  +--ro oper-state?                            oc-cfm-types:operational-state-type
     |                 |  +--ro interface-state?                       oc-cfm-types:interface-status-type
     |                 |  +--ro fng-state?                             oc-cfm-types:fng-state-type
     |                 |  +--ro highest-priority-defect?               oc-cfm-types:highest-defect-priority-type
     |                 |  +--ro mep-defects*                           oc-cfm-types:mep-defects-type
     |                 |  +--ro present-rdi?                           boolean
     |                 |  +--ro config-errors-detected*                oc-cfm-types:config-error-type
     |                 |  +--ro error-ccm-last-failure?                binary
     |                 |  +--ro counters
     |                 |     +--ro mep-ccm-sequence-errors    oc-yang:counter64
     |                 |     +--ro mep-ccms-sent              oc-yang:counter64
     |                 +--rw pm-profiles
     |                 |  +--rw pm-profile* [profile-name]
     |                 |     +--rw profile-name    -> ../../../../../../../../../performance-measurement-profiles-global/performance-measurement-profile/config/profile-name
     |                 |     +--rw config
     |                 |     +--ro state
     |                 |        +--ro loss-measurement-state
     |                 |        |  +--ro far-end-min-frame-loss-ratio?        uint32
     |                 |        |  +--ro far-end-max-frame-loss-ratio?        uint32
     |                 |        |  +--ro far-end-average-frame-loss-ratio?    uint32
     |                 |        |  +--ro near-end-min-frame-loss-ratio?       uint32
     |                 |        |  +--ro near-end-max-frame-loss-ratio?       uint32
     |                 |        |  +--ro near-end-average-frame-loss-ratio?   uint32
     |                 |        |  +--ro counters
     |                 |        |     +--ro slm-sent?       oc-yang:counter64
     |                 |        |     +--ro slm-received?   oc-yang:counter64
     |                 |        |     +--ro slr-sent?       oc-yang:counter64
     |                 |        |     +--ro slr-received?   oc-yang:counter64
     |                 |        +--ro delay-measurement-state
     |                 |           +--ro frame-delay-two-way-min?       uint32
     |                 |           +--ro frame-delay-two-way-max?       uint32
     |                 |           +--ro frame-delay-two-way-average?   uint32
     |                 |           +--ro frame-delay-two-way-stddev?    uint32
     |                 |           +--ro counters
     |                 |              +--ro dmm-sent?       oc-yang:counter64
     |                 |              +--ro dmm-received?   oc-yang:counter64
     |                 |              +--ro dmr-sent?       oc-yang:counter64
     |                 |              +--ro dmr-received?   oc-yang:counter64
     |                 +--rw rdi
     |                 |  +--rw config
     |                 |  |  +--rw transmit-on-defect?   boolean
     |                 |  +--ro state
     |                 |     +--ro transmit-on-defect?   boolean
     |                 +--rw link-loss-forwarding
     |                 |  +--rw config
     |                 |  |  +--rw enable?   boolean
     |                 |  |  +--rw action?   enumeration
     |                 |  +--ro state
     |                 |     +--ro enable?   boolean
     |                 |     +--ro action?   enumeration
     |                 +--rw remote-meps
     |                    +--rw remote-mep* [id]
     |                       +--rw id        -> ../config/id
     |                       +--rw config
     |                       |  +--rw id?            oc-cfm-types:mep-id-type
     |                       |  +--rw mac-address?   oc-yang:mac-address
     |                       +--ro state
     |                          +--ro id?                        oc-cfm-types:mep-id-type
     |                          +--ro mac-address?               oc-yang:mac-address
     |                          +--ro oper-state?                oc-cfm-types:operational-state-type
     |                          +--ro interface-state?           oc-cfm-types:interface-status-type
     |                          +--ro fng-state?                 oc-cfm-types:fng-state-type
     |                          +--ro highest-priority-defect?   oc-cfm-types:highest-defect-priority-type
     |                          +--ro mep-defects*               oc-cfm-types:mep-defects-type
     |                          +--ro present-rdi?               boolean
     |                          +--ro config-errors-detected*    oc-cfm-types:config-error-type
     |                          +--ro error-ccm-last-failure?    binary
     |                          +--ro counters
     |                             +--ro mep-ccm-sequence-errors    oc-yang:counter64
     |                             +--ro mep-ccms-sent              oc-yang:counter64
     +--ro state
     |  +--ro local-meps?                    uint32
     |  +--ro local-meps-operational?        uint32
     |  +--ro cfm-domains?                   uint32
     |  +--ro cfm-services?                  uint32
     |  +--ro down-meps?                     uint32
     |  +--ro up-meps?                       uint32
     |  +--ro disabled-misconfigured?        uint32
     |  +--ro disabled-operational-errors?   uint32
     |  +--ro disabled-out-of-resources?     uint32
     |  +--ro peer-meps?                     uint32
     |  +--ro operational-peer-meps?         uint32
     |  +--ro peer-meps-with-defects?        uint32
     |  +--ro peer-meps-timed-out?           uint32
     +--rw performance-measurement-profiles-global
        +--rw performance-measurement-profile* [profile-name]
           +--rw profile-name    -> ../config/profile-name
           +--rw config
           |  +--rw profile-name?                    string
           |  +--rw enable?                          boolean
           |  +--rw measurement-type?                enumeration
           |  +--rw protocol-type?                   enumeration
           |  +--rw frame-size?                      uint16
           |  +--rw measurement-interval?            uint32
           |  +--rw repetition-period?               uint32
           |  +--rw intervals-archived?              uint16
           |  +--rw packets-per-meaurement-period?   uint16
           |  +--rw burst-interval?                  uint32
           |  +--rw packet-per-burst?                uint32
           +--ro state
              +--ro profile-name?                    string
              +--ro enable?                          boolean
              +--ro measurement-type?                enumeration
              +--ro protocol-type?                   enumeration
              +--ro frame-size?                      uint16
              +--ro measurement-interval?            uint32
              +--ro repetition-period?               uint32
              +--ro intervals-archived?              uint16
              +--ro packets-per-meaurement-period?   uint16
              +--ro burst-interval?                  uint32
              +--ro packet-per-burst?                uint32
              +--ro loss-measurement-state
              |  +--ro far-end-min-frame-loss-ratio?        uint32
              |  +--ro far-end-max-frame-loss-ratio?        uint32
              |  +--ro far-end-average-frame-loss-ratio?    uint32
              |  +--ro near-end-min-frame-loss-ratio?       uint32
              |  +--ro near-end-max-frame-loss-ratio?       uint32
              |  +--ro near-end-average-frame-loss-ratio?   uint32
              |  +--ro counters
              |     +--ro slm-sent?       oc-yang:counter64
              |     +--ro slm-received?   oc-yang:counter64
              |     +--ro slr-sent?       oc-yang:counter64
              |     +--ro slr-received?   oc-yang:counter64
              +--ro delay-measurement-state
                 +--ro frame-delay-two-way-min?       uint32
                 +--ro frame-delay-two-way-max?       uint32
                 +--ro frame-delay-two-way-average?   uint32
                 +--ro frame-delay-two-way-stddev?    uint32
                 +--ro counters
                    +--ro dmm-sent?       oc-yang:counter64
                    +--ro dmm-received?   oc-yang:counter64
                    +--ro dmr-sent?       oc-yang:counter64
                    +--ro dmr-received?   oc-yang:counter64

release/models/cfm/openconfig-cfm-types.yang

release/models/cfm/openconfig-cfm.yang

earies · 2024-09-18T19:46:37Z

release/models/cfm/openconfig-cfm.yang

+    }
+  }
+
+  uses cfm-top;


Should there be some hierarchical structure to group OAM vs. CFM directly at the root?

I support this to hopefully get a Juniper LFM augmentation.

earies are you suggesting we have an umbrella node; i.e "openconfig/EthernetOAM/cfm"?

Yes, how about adding a top level container for /oam and nesting cfm under that as: /oam/cfm

So a specific proposal is to create a openconfig-oam.yang file with the top level /oam container. Then another file for openconfig-oam-cfm.yang which augments the /oam path.

dplore · 2024-09-18T20:58:33Z

/gcbrun

OpenConfigBot · 2024-09-18T20:59:59Z

No major YANG version changes in commit 8773950

* removes trailing spaces. * removes unused and non OC flavoured imports (ietf). * moves leaf nomenclature from "_" to "-" . * add damping timer leaf to LLF feature.

AnnamalaiRajeev · 2024-09-19T12:55:36Z

Tree view Commit 7

module: openconfig-cfm
  +--rw cfm
     +--rw domains
     |  +--rw maintenance-domain* [md-id]
     |     +--rw md-id                       -> ../config/md-id
     |     +--rw config
     |     |  +--rw md-id?           oc-cfm-types:name-key-type
     |     |  +--rw level?           uint8
     |     |  +--rw md-name-type?    enumeration
     |     |  +--rw none?            boolean
     |     |  +--rw dns-like-name?   string
     |     |  +--rw address          oc-yang:mac-address
     |     |  +--rw unsigned-int     uint16
     |     |  +--rw char-string?     string
     |     +--ro state
     |     |  +--ro md-id?           oc-cfm-types:name-key-type
     |     |  +--ro level?           uint8
     |     |  +--ro md-name-type?    enumeration
     |     |  +--ro none?            boolean
     |     |  +--ro dns-like-name?   string
     |     |  +--ro address          oc-yang:mac-address
     |     |  +--ro unsigned-int     uint16
     |     |  +--ro char-string?     string
     |     +--rw maintenance-associations
     |        +--rw maintenance-association* [ma-id]
     |           +--rw ma-id            -> ../config/ma-id
     |           +--rw config
     |           |  +--rw ma-id?            oc-cfm-types:name-key-type
     |           |  +--rw group-name?       string
     |           |  +--rw ma-name-type?     enumeration
     |           |  +--rw primary-vid       oc-vlan-types:vlan-id
     |           |  +--rw char-string       string
     |           |  +--rw unsigned-int16    uint16
     |           |  +--rw vpn-oui           uint32
     |           |  +--rw vpn-index         uint32
     |           |  +--rw ccm-interval?     enumeration
     |           |  +--rw loss-threshold?   uint16
     |           +--ro state
     |           |  +--ro ma-id?            oc-cfm-types:name-key-type
     |           |  +--ro group-name?       string
     |           |  +--ro ma-name-type?     enumeration
     |           |  +--ro primary-vid       oc-vlan-types:vlan-id
     |           |  +--ro char-string       string
     |           |  +--ro unsigned-int16    uint16
     |           |  +--ro vpn-oui           uint32
     |           |  +--ro vpn-index         uint32
     |           |  +--ro ccm-interval?     enumeration
     |           |  +--ro loss-threshold?   uint16
     |           +--rw mep-endpoints
     |              +--rw mep-endpoint* [local-mep-id]
     |                 +--rw local-mep-id            -> ../config/local-mep-id
     |                 +--rw config
     |                 |  +--rw ccm-enabled?                           boolean
     |                 |  +--rw lowest-priority-defect?                oc-cfm-types:lowest-alarm-priority-type
     |                 |  +--rw fng-alarm-time?                        uint16
     |                 |  +--rw fng-reset-time?                        uint16
     |                 |  +--rw local-mep-id?                          oc-cfm-types:mep-id-type
     |                 |  +--rw interface?                             -> /oc-if:interfaces/interface/name
     |                 |  +--rw include-mep-port-status-in-tlv?        boolean
     |                 |  +--rw include-mep-interface-status-in-tlv?   boolean
     |                 |  +--rw direction?                             enumeration
     |                 +--ro state
     |                 |  +--ro ccm-enabled?                           boolean
     |                 |  +--ro lowest-priority-defect?                oc-cfm-types:lowest-alarm-priority-type
     |                 |  +--ro fng-alarm-time?                        uint16
     |                 |  +--ro fng-reset-time?                        uint16
     |                 |  +--ro local-mep-id?                          oc-cfm-types:mep-id-type
     |                 |  +--ro interface?                             -> /oc-if:interfaces/interface/name
     |                 |  +--ro include-mep-port-status-in-tlv?        boolean
     |                 |  +--ro include-mep-interface-status-in-tlv?   boolean
     |                 |  +--ro direction?                             enumeration
     |                 |  +--ro oper-state?                            oc-cfm-types:operational-state-type
     |                 |  +--ro interface-state?                       oc-cfm-types:interface-status-type
     |                 |  +--ro fng-state?                             oc-cfm-types:fng-state-type
     |                 |  +--ro highest-priority-defect?               oc-cfm-types:highest-defect-priority-type
     |                 |  +--ro mep-defects*                           oc-cfm-types:mep-defects-type
     |                 |  +--ro present-rdi?                           boolean
     |                 |  +--ro config-errors-detected*                oc-cfm-types:config-error-type
     |                 |  +--ro error-ccm-last-failure?                binary
     |                 |  +--ro counters
     |                 |     +--ro mep-ccm-sequence-errors    oc-yang:counter64
     |                 |     +--ro mep-ccms-sent              oc-yang:counter64
     |                 +--rw pm-profiles
     |                 |  +--rw pm-profile* [profile-name]
     |                 |     +--rw profile-name    -> ../../../../../../../../../performance-measurement-profiles-global/performance-measurement-profile/config/profile-name
     |                 |     +--rw config
     |                 |     +--ro state
     |                 |        +--ro loss-measurement-state
     |                 |        |  +--ro far-end-min-frame-loss-ratio?        uint32
     |                 |        |  +--ro far-end-max-frame-loss-ratio?        uint32
     |                 |        |  +--ro far-end-average-frame-loss-ratio?    uint32
     |                 |        |  +--ro near-end-min-frame-loss-ratio?       uint32
     |                 |        |  +--ro near-end-max-frame-loss-ratio?       uint32
     |                 |        |  +--ro near-end-average-frame-loss-ratio?   uint32
     |                 |        |  +--ro counters
     |                 |        |     +--ro slm-sent?       oc-yang:counter64
     |                 |        |     +--ro slm-received?   oc-yang:counter64
     |                 |        |     +--ro slr-sent?       oc-yang:counter64
     |                 |        |     +--ro slr-received?   oc-yang:counter64
     |                 |        +--ro delay-measurement-state
     |                 |           +--ro frame-delay-two-way-min?       uint32
     |                 |           +--ro frame-delay-two-way-max?       uint32
     |                 |           +--ro frame-delay-two-way-average?   uint32
     |                 |           +--ro frame-delay-two-way-stddev?    uint32
     |                 |           +--ro counters
     |                 |              +--ro dmm-sent?       oc-yang:counter64
     |                 |              +--ro dmm-received?   oc-yang:counter64
     |                 |              +--ro dmr-sent?       oc-yang:counter64
     |                 |              +--ro dmr-received?   oc-yang:counter64
     |                 +--rw rdi
     |                 |  +--rw config
     |                 |  |  +--rw transmit-on-defect?   boolean
     |                 |  +--ro state
     |                 |     +--ro transmit-on-defect?   boolean
     |                 +--rw link-loss-forwarding
     |                 |  +--rw config
     |                 |  |  +--rw enable?          boolean
     |                 |  |  +--rw damping-timer?   uint64
     |                 |  |  +--rw action?          enumeration
     |                 |  +--ro state
     |                 |     +--ro enable?          boolean
     |                 |     +--ro damping-timer?   uint64
     |                 |     +--ro action?          enumeration
     |                 +--rw remote-meps
     |                    +--rw remote-mep* [id]
     |                       +--rw id        -> ../config/id
     |                       +--rw config
     |                       |  +--rw id?            oc-cfm-types:mep-id-type
     |                       |  +--rw mac-address?   oc-yang:mac-address
     |                       +--ro state
     |                          +--ro id?                        oc-cfm-types:mep-id-type
     |                          +--ro mac-address?               oc-yang:mac-address
     |                          +--ro oper-state?                oc-cfm-types:operational-state-type
     |                          +--ro interface-state?           oc-cfm-types:interface-status-type
     |                          +--ro fng-state?                 oc-cfm-types:fng-state-type
     |                          +--ro highest-priority-defect?   oc-cfm-types:highest-defect-priority-type
     |                          +--ro mep-defects*               oc-cfm-types:mep-defects-type
     |                          +--ro present-rdi?               boolean
     |                          +--ro config-errors-detected*    oc-cfm-types:config-error-type
     |                          +--ro error-ccm-last-failure?    binary
     |                          +--ro counters
     |                             +--ro mep-ccm-sequence-errors    oc-yang:counter64
     |                             +--ro mep-ccms-sent              oc-yang:counter64
     +--ro state
     |  +--ro local-meps?                    uint32
     |  +--ro local-meps-operational?        uint32
     |  +--ro cfm-domains?                   uint32
     |  +--ro cfm-services?                  uint32
     |  +--ro down-meps?                     uint32
     |  +--ro up-meps?                       uint32
     |  +--ro disabled-misconfigured?        uint32
     |  +--ro disabled-operational-errors?   uint32
     |  +--ro disabled-out-of-resources?     uint32
     |  +--ro peer-meps?                     uint32
     |  +--ro operational-peer-meps?         uint32
     |  +--ro peer-meps-with-defects?        uint32
     |  +--ro peer-meps-timed-out?           uint32
     +--rw performance-measurement-profiles-global
        +--rw performance-measurement-profile* [profile-name]
           +--rw profile-name    -> ../config/profile-name
           +--rw config
           |  +--rw profile-name?                    string
           |  +--rw enable?                          boolean
           |  +--rw measurement-type?                enumeration
           |  +--rw protocol-type?                   enumeration
           |  +--rw frame-size?                      uint16
           |  +--rw measurement-interval?            uint32
           |  +--rw repetition-period?               uint32
           |  +--rw intervals-archived?              uint16
           |  +--rw packets-per-meaurement-period?   uint16
           |  +--rw burst-interval?                  uint32
           |  +--rw packet-per-burst?                uint32
           +--ro state
              +--ro profile-name?                    string
              +--ro enable?                          boolean
              +--ro measurement-type?                enumeration
              +--ro protocol-type?                   enumeration
              +--ro frame-size?                      uint16
              +--ro measurement-interval?            uint32
              +--ro repetition-period?               uint32
              +--ro intervals-archived?              uint16
              +--ro packets-per-meaurement-period?   uint16
              +--ro burst-interval?                  uint32
              +--ro packet-per-burst?                uint32
              +--ro loss-measurement-state
              |  +--ro far-end-min-frame-loss-ratio?        uint32
              |  +--ro far-end-max-frame-loss-ratio?        uint32
              |  +--ro far-end-average-frame-loss-ratio?    uint32
              |  +--ro near-end-min-frame-loss-ratio?       uint32
              |  +--ro near-end-max-frame-loss-ratio?       uint32
              |  +--ro near-end-average-frame-loss-ratio?   uint32
              |  +--ro counters
              |     +--ro slm-sent?       oc-yang:counter64
              |     +--ro slm-received?   oc-yang:counter64
              |     +--ro slr-sent?       oc-yang:counter64
              |     +--ro slr-received?   oc-yang:counter64
              +--ro delay-measurement-state
                 +--ro frame-delay-two-way-min?       uint32
                 +--ro frame-delay-two-way-max?       uint32
                 +--ro frame-delay-two-way-average?   uint32
                 +--ro frame-delay-two-way-stddev?    uint32
                 +--ro counters
                    +--ro dmm-sent?       oc-yang:counter64
                    +--ro dmm-received?   oc-yang:counter64
                    +--ro dmr-sent?       oc-yang:counter64
                    +--ro dmr-received?   oc-yang:counter64

* edit to ccm interval: remove 300ms and add 100ms enum.

nleiva · 2024-09-24T14:45:00Z

Good job @AnnamalaiRajeev. The only thing I couldn't map from our current configs is the option to enable automatic discovery of a MEP. Is there any other way to represent this in the model? Thanks

Juniper description: "With automatic discovery a MEP is enabled to accept continuity check messages (CCMs) from all remote MEPs of the same maintenance association. If automatic discovery is not enabled, the remote MEPs must be configured. If the remote MEP is not configured, the CCMs from the remote MEP are treated as errors."

dplore · 2024-09-24T16:27:11Z

/gcbrun

dplore · 2024-09-25T19:00:23Z

/gcbrun

AnnamalaiRajeev · 2024-10-08T16:07:10Z

AI:

add OAM file and have cfm augmented

…th cfm." This reverts commit fd9e301. * revert commit to pull and push

…into cfm_branch sync remote

…files

dplore · 2024-10-18T22:45:32Z

/gcbrun

dplore · 2024-10-25T01:20:28Z

/gcbrun

dplore · 2024-11-12T05:34:11Z

Last call for comments. This will merge on Nov 19, 2024

dplore · 2024-11-12T16:32:06Z

@AnnamalaiRajeev follow up comment from last week's operator review:

Please add a leaf for MEP auto-discovery. Because there is not a standard for the default value, then don’t specify a default in yang, rather users must configure explicitly true or false. If unset, then it’s implementation specific.

Merge branch 'cfm_branch' of https://github.com/AnnamalaiRajeev/public into cfm_branch

AnnamalaiRajeev · 2024-11-12T16:59:48Z

@AnnamalaiRajeev follow up comment from last week's operator review:

Please add a leaf for MEP auto-discovery. Because there is not a standard for the default value, then don’t specify a default in yang, rather users must configure explicitly true or false. If unset, then it’s implementation specific.

This is done. ptal thx

AnnamalaiRajeev · 2024-11-12T17:04:52Z

Commit 20 . # last call

/anamalai/oam/google3/third_party/openconfig/public/release/models/oam/openconfig-oam-cfm.yang
module: openconfig-oam-cfm

  augment /oc-oam:oam:
    +--rw cfm
       +--rw domains
       |  +--rw maintenance-domain* [md-id]
       |     +--rw md-id                       -> ../config/md-id
       |     +--rw config
       |     |  +--rw md-id?           oc-cfm-types:name-key-type
       |     |  +--rw level?           uint8
       |     |  +--rw md-name-type?    enumeration
       |     |  +--rw none?            boolean
       |     |  +--rw dns-like-name?   string
       |     |  +--rw address          oc-yang:mac-address
       |     |  +--rw unsigned-int     uint16
       |     |  +--rw char-string?     string
       |     +--ro state
       |     |  +--ro md-id?           oc-cfm-types:name-key-type
       |     |  +--ro level?           uint8
       |     |  +--ro md-name-type?    enumeration
       |     |  +--ro none?            boolean
       |     |  +--ro dns-like-name?   string
       |     |  +--ro address          oc-yang:mac-address
       |     |  +--ro unsigned-int     uint16
       |     |  +--ro char-string?     string
       |     +--rw maintenance-associations
       |        +--rw maintenance-association* [ma-id]
       |           +--rw ma-id            -> ../config/ma-id
       |           +--rw config
       |           |  +--rw ma-id?            oc-cfm-types:name-key-type
       |           |  +--rw group-name?       string
       |           |  +--rw ma-name-type?     enumeration
       |           |  +--rw primary-vid       oc-vlan-types:vlan-id
       |           |  +--rw char-string       string
       |           |  +--rw unsigned-int16    uint16
       |           |  +--rw vpn-oui           uint32
       |           |  +--rw vpn-index         uint32
       |           |  +--rw ccm-interval?     enumeration
       |           |  +--rw loss-threshold?   uint16
       |           +--ro state
       |           |  +--ro ma-id?            oc-cfm-types:name-key-type
       |           |  +--ro group-name?       string
       |           |  +--ro ma-name-type?     enumeration
       |           |  +--ro primary-vid       oc-vlan-types:vlan-id
       |           |  +--ro char-string       string
       |           |  +--ro unsigned-int16    uint16
       |           |  +--ro vpn-oui           uint32
       |           |  +--ro vpn-index         uint32
       |           |  +--ro ccm-interval?     enumeration
       |           |  +--ro loss-threshold?   uint16
       |           +--rw mep-endpoints
       |              +--rw mep-endpoint* [local-mep-id]
       |                 +--rw local-mep-id            -> ../config/local-mep-id
       |                 +--rw config
       |                 |  +--rw ccm-enabled?                           boolean
       |                 |  +--rw lowest-priority-defect?                oc-cfm-types:lowest-alarm-priority-type
       |                 |  +--rw fng-alarm-time?                        uint16
       |                 |  +--rw fng-reset-time?                        uint16
       |                 |  +--rw local-mep-id?                          oc-cfm-types:mep-id-type
       |                 |  +--rw interface?                             -> /oc-if:interfaces/interface/name
       |                 |  +--rw include-mep-port-status-in-tlv?        boolean
       |                 |  +--rw include-mep-interface-status-in-tlv?   boolean
       |                 |  +--rw direction?                             enumeration
       |                 |  +--rw auto-discovery?                        boolean
       |                 +--ro state
       |                 |  +--ro ccm-enabled?                           boolean
       |                 |  +--ro lowest-priority-defect?                oc-cfm-types:lowest-alarm-priority-type
       |                 |  +--ro fng-alarm-time?                        uint16
       |                 |  +--ro fng-reset-time?                        uint16
       |                 |  +--ro local-mep-id?                          oc-cfm-types:mep-id-type
       |                 |  +--ro interface?                             -> /oc-if:interfaces/interface/name
       |                 |  +--ro include-mep-port-status-in-tlv?        boolean
       |                 |  +--ro include-mep-interface-status-in-tlv?   boolean
       |                 |  +--ro direction?                             enumeration
       |                 |  +--ro auto-discovery?                        boolean
       |                 |  +--ro oper-state?                            oc-cfm-types:operational-state-type
       |                 |  +--ro interface-state?                       oc-cfm-types:interface-status-type
       |                 |  +--ro fng-state?                             oc-cfm-types:fng-state-type
       |                 |  +--ro highest-priority-defect?               oc-cfm-types:highest-defect-priority-type
       |                 |  +--ro mep-defects*                           oc-cfm-types:mep-defects-type
       |                 |  +--ro present-rdi?                           boolean
       |                 |  +--ro config-errors-detected*                oc-cfm-types:config-error-type
       |                 |  +--ro error-ccm-last-failure?                binary
       |                 |  +--ro counters
       |                 |     +--ro mep-ccm-sequence-errors    oc-yang:counter64
       |                 |     +--ro mep-ccms-sent              oc-yang:counter64
       |                 +--rw pm-profiles
       |                 |  +--rw pm-profile* [profile-name]
       |                 |     +--rw profile-name    -> ../config/profile-name
       |                 |     +--rw config
       |                 |     |  +--rw profile-name?   string
       |                 |     +--ro state
       |                 |        +--ro profile-name?                    string
       |                 |        +--ro enable?                          boolean
       |                 |        +--ro measurement-type?                enumeration
       |                 |        +--ro protocol-type?                   enumeration
       |                 |        +--ro frame-size?                      uint16
       |                 |        +--ro measurement-interval?            uint32
       |                 |        +--ro repetition-period?               uint32
       |                 |        +--ro intervals-archived?              uint16
       |                 |        +--ro packets-per-meaurement-period?   uint16
       |                 |        +--ro burst-interval?                  uint32
       |                 |        +--ro packet-per-burst?                uint32
       |                 |        +--ro loss-measurement-state
       |                 |        |  +--ro far-end-min-frame-loss-ratio?        uint32
       |                 |        |  +--ro far-end-max-frame-loss-ratio?        uint32
       |                 |        |  +--ro far-end-average-frame-loss-ratio?    uint32
       |                 |        |  +--ro near-end-min-frame-loss-ratio?       uint32
       |                 |        |  +--ro near-end-max-frame-loss-ratio?       uint32
       |                 |        |  +--ro near-end-average-frame-loss-ratio?   uint32
       |                 |        |  +--ro counters
       |                 |        |     +--ro slm-sent?       oc-yang:counter64
       |                 |        |     +--ro slm-received?   oc-yang:counter64
       |                 |        |     +--ro slr-sent?       oc-yang:counter64
       |                 |        |     +--ro slr-received?   oc-yang:counter64
       |                 |        +--ro delay-measurement-state
       |                 |           +--ro frame-delay-two-way-min?       uint32
       |                 |           +--ro frame-delay-two-way-max?       uint32
       |                 |           +--ro frame-delay-two-way-average?   uint32
       |                 |           +--ro frame-delay-two-way-stddev?    uint32
       |                 |           +--ro counters
       |                 |              +--ro dmm-sent?       oc-yang:counter64
       |                 |              +--ro dmm-received?   oc-yang:counter64
       |                 |              +--ro dmr-sent?       oc-yang:counter64
       |                 |              +--ro dmr-received?   oc-yang:counter64
       |                 +--rw rdi
       |                 |  +--rw config
       |                 |  |  +--rw transmit-on-defect?   boolean
       |                 |  +--ro state
       |                 |     +--ro transmit-on-defect?   boolean
       |                 +--rw link-loss-forwarding
       |                 |  +--rw config
       |                 |  |  +--rw enable?          boolean
       |                 |  |  +--rw damping-timer?   uint64
       |                 |  |  +--rw action?          enumeration
       |                 |  +--ro state
       |                 |     +--ro enable?          boolean
       |                 |     +--ro damping-timer?   uint64
       |                 |     +--ro action?          enumeration
       |                 +--rw remote-meps
       |                    +--rw remote-mep* [id]
       |                       +--rw id        -> ../config/id
       |                       +--rw config
       |                       |  +--rw id?            oc-cfm-types:mep-id-type
       |                       |  +--rw mac-address?   oc-yang:mac-address
       |                       +--ro state
       |                          +--ro id?                        oc-cfm-types:mep-id-type
       |                          +--ro mac-address?               oc-yang:mac-address
       |                          +--ro oper-state?                oc-cfm-types:operational-state-type
       |                          +--ro interface-state?           oc-cfm-types:interface-status-type
       |                          +--ro fng-state?                 oc-cfm-types:fng-state-type
       |                          +--ro highest-priority-defect?   oc-cfm-types:highest-defect-priority-type
       |                          +--ro mep-defects*               oc-cfm-types:mep-defects-type
       |                          +--ro present-rdi?               boolean
       |                          +--ro config-errors-detected*    oc-cfm-types:config-error-type
       |                          +--ro error-ccm-last-failure?    binary
       |                          +--ro counters
       |                             +--ro mep-ccm-sequence-errors    oc-yang:counter64
       |                             +--ro mep-ccms-sent              oc-yang:counter64
       +--ro state
       |  +--ro local-meps?                    uint32
       |  +--ro local-meps-operational?        uint32
       |  +--ro cfm-domains?                   uint32
       |  +--ro cfm-services?                  uint32
       |  +--ro down-meps?                     uint32
       |  +--ro up-meps?                       uint32
       |  +--ro disabled-misconfigured?        uint32
       |  +--ro disabled-operational-errors?   uint32
       |  +--ro disabled-out-of-resources?     uint32
       |  +--ro peer-meps?                     uint32
       |  +--ro operational-peer-meps?         uint32
       |  +--ro peer-meps-with-defects?        uint32
       |  +--ro peer-meps-timed-out?           uint32
       +--rw performance-measurement-profiles-global
          +--rw performance-measurement-profile* [profile-name]
             +--rw profile-name    -> ../config/profile-name
             +--rw config
             |  +--rw profile-name?                    string
             |  +--rw enable?                          boolean
             |  +--rw measurement-type?                enumeration
             |  +--rw protocol-type?                   enumeration
             |  +--rw frame-size?                      uint16
             |  +--rw measurement-interval?            uint32
             |  +--rw repetition-period?               uint32
             |  +--rw intervals-archived?              uint16
             |  +--rw packets-per-meaurement-period?   uint16
             |  +--rw burst-interval?                  uint32
             |  +--rw packet-per-burst?                uint32
             +--ro state
                +--ro profile-name?                    string
                +--ro enable?                          boolean
                +--ro measurement-type?                enumeration
                +--ro protocol-type?                   enumeration
                +--ro frame-size?                      uint16
                +--ro measurement-interval?            uint32
                +--ro repetition-period?               uint32
                +--ro intervals-archived?              uint16
                +--ro packets-per-meaurement-period?   uint16
                +--ro burst-interval?                  uint32
                +--ro packet-per-burst?                uint32
                +--ro loss-measurement-state
                |  +--ro far-end-min-frame-loss-ratio?        uint32
                |  +--ro far-end-max-frame-loss-ratio?        uint32
                |  +--ro far-end-average-frame-loss-ratio?    uint32
                |  +--ro near-end-min-frame-loss-ratio?       uint32
                |  +--ro near-end-max-frame-loss-ratio?       uint32
                |  +--ro near-end-average-frame-loss-ratio?   uint32
                |  +--ro counters
                |     +--ro slm-sent?       oc-yang:counter64
                |     +--ro slm-received?   oc-yang:counter64
                |     +--ro slr-sent?       oc-yang:counter64
                |     +--ro slr-received?   oc-yang:counter64
                +--ro delay-measurement-state
                   +--ro frame-delay-two-way-min?       uint32
                   +--ro frame-delay-two-way-max?       uint32
                   +--ro frame-delay-two-way-average?   uint32
                   +--ro frame-delay-two-way-stddev?    uint32
                   +--ro counters
                      +--ro dmm-sent?       oc-yang:counter64
                      +--ro dmm-received?   oc-yang:counter64
                      +--ro dmr-sent?       oc-yang:counter64
                      +--ro dmr-received?   oc-yang:counter64

dplore · 2024-11-13T08:25:34Z

/gcbrun

GokusSGUltra added 2 commits September 17, 2024 06:25

CFM version 1

f096a18

add y1731 profile states

da9cf4a

AnnamalaiRajeev requested a review from a team as a code owner September 17, 2024 16:15

Add leaf for average frame loss in egress direction

5df107f

dplore self-assigned this Sep 17, 2024

GokusSGUltra added 2 commits September 18, 2024 07:33

fix seggregation for performance-mesurement-state.

4219428

fix descriptions.

28b6cf9

earies reviewed Sep 18, 2024

View reviewed changes

release/models/cfm/openconfig-cfm-types.yang Outdated Show resolved Hide resolved

earies reviewed Sep 18, 2024

View reviewed changes

release/models/cfm/openconfig-cfm.yang Outdated Show resolved Hide resolved

earies reviewed Sep 18, 2024

View reviewed changes

OpenConfigBot added the non-breaking label Sep 18, 2024

commit 7 adds following

69c941c

* removes trailing spaces. * removes unused and non OC flavoured imports (ietf). * moves leaf nomenclature from "_" to "-" . * add damping timer leaf to LLF feature.

GokusSGUltra added 3 commits September 22, 2024 09:45

* refractor leaf-ref "profile-name" to point to config.

3aa5484

* edit to ccm interval: remove 300ms and add 100ms enum.

* fix typo for profile-name under config.

b503076

change unit for packets-per-burst

fb67fde

Merge branch 'master' into cfm_branch

de21412

GokusSGUltra added 4 commits October 18, 2024 15:15

* refractor cfm module. add oam super node and augment OAM with cfm.

fd9e301

Revert "* refractor cfm module. add oam super node and augment OAM wi…

e1b9dac

…th cfm." This reverts commit fd9e301. * revert commit to pull and push

Merge branch 'cfm_branch' of https://github.com/AnnamalaiRajeev/public …

57fa1b2

…into cfm_branch sync remote

add oam super node and refractor cfm + add state variables to pm pro…

1dfb64e

…files

GokusSGUltra and others added 2 commits October 23, 2024 14:55

add posix-regex extension statements to fix lint

8370bcd

Merge branch 'master' into cfm_branch

5336cd9

dplore added the last-call PR that is in final review before merging. label Nov 12, 2024

GokusSGUltra added 2 commits November 12, 2024 08:56

"add auto discovery knob"

23b9087

"add auto-discovery knob"

8a990f7

Merge branch 'cfm_branch' of https://github.com/AnnamalaiRajeev/public into cfm_branch

remove trailing spaces

8773950

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

IEEE 802.1AG CFM connectivity management + ITU Y1731 Performance management #1182

IEEE 802.1AG CFM connectivity management + ITU Y1731 Performance management #1182

AnnamalaiRajeev commented Sep 17, 2024 •

edited

Loading

google-cla bot commented Sep 17, 2024

AnnamalaiRajeev commented Sep 18, 2024

earies Sep 18, 2024

nleiva Sep 19, 2024

AnnamalaiRajeev Sep 19, 2024

dplore Sep 24, 2024

dplore Oct 8, 2024

dplore commented Sep 18, 2024

OpenConfigBot commented Sep 18, 2024 •

edited

Loading

AnnamalaiRajeev commented Sep 19, 2024

nleiva commented Sep 24, 2024

dplore commented Sep 24, 2024

dplore commented Sep 25, 2024

AnnamalaiRajeev commented Oct 8, 2024

dplore commented Oct 18, 2024

dplore commented Oct 25, 2024

dplore commented Nov 12, 2024

dplore commented Nov 12, 2024

AnnamalaiRajeev commented Nov 12, 2024

AnnamalaiRajeev commented Nov 12, 2024

dplore commented Nov 13, 2024

IEEE 802.1AG CFM connectivity management + ITU Y1731 Performance management #1182

Are you sure you want to change the base?

IEEE 802.1AG CFM connectivity management + ITU Y1731 Performance management #1182

Conversation

AnnamalaiRajeev commented Sep 17, 2024 • edited Loading

Change Scope

Platform Implementations

google-cla bot commented Sep 17, 2024

AnnamalaiRajeev commented Sep 18, 2024

earies Sep 18, 2024

Choose a reason for hiding this comment

nleiva Sep 19, 2024

Choose a reason for hiding this comment

AnnamalaiRajeev Sep 19, 2024

Choose a reason for hiding this comment

dplore Sep 24, 2024

Choose a reason for hiding this comment

dplore Oct 8, 2024

Choose a reason for hiding this comment

dplore commented Sep 18, 2024

OpenConfigBot commented Sep 18, 2024 • edited Loading

AnnamalaiRajeev commented Sep 19, 2024

Tree view Commit 7

nleiva commented Sep 24, 2024

dplore commented Sep 24, 2024

dplore commented Sep 25, 2024

AnnamalaiRajeev commented Oct 8, 2024

dplore commented Oct 18, 2024

dplore commented Oct 25, 2024

dplore commented Nov 12, 2024

dplore commented Nov 12, 2024

AnnamalaiRajeev commented Nov 12, 2024

AnnamalaiRajeev commented Nov 12, 2024

Commit 20 . # last call

dplore commented Nov 13, 2024

AnnamalaiRajeev commented Sep 17, 2024 •

edited

Loading

OpenConfigBot commented Sep 18, 2024 •

edited

Loading