Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify when a verify UNAVAILABLE gRPC error is expected #223

Closed
wants to merge 2 commits into from
Closed

Clarify when a verify UNAVAILABLE gRPC error is expected #223

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ead75f
Clarify that an UNAVAILABLE gRPC error is expected
yvetteyuanw Nov 7, 2024
b922c60
Clarify that an UNAVAILABLE gRPC error is expected
yvetteyuanw Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions os/os.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,10 +145,10 @@ service OS {
rpc Activate(ActivateRequest) returns (ActivateResponse);

// Verify checks the running OS version. During reboot, gRPC client returns
// the gRPC status code UNAVAILABLE while the Target is unreachable, which
// should be retried by the client until successful. After the Target becomes
// reachable, it should report all ready or error states normally through
// VerifyResponse.
// the gRPC status code UNAVAILABLE while the Target is unreachable or still
// performing install operation, which should be retried by the client until
// successful. After the Target becomes available, it should report all ready
// or error states normally through VerifyResponse.
//
// On a dual Supervisor system, if the Standby Supervisor is rebooting, it
// should be reported in the VerifyResponse via verify_standby as
Expand Down
Loading