link-parser fixes #1536
Merged
link-parser fixes #1536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test and debug parse options defaults were incorrectly recorded when set by link-parser's arguments. The program crashes upon command completion of !dialect= if the dialect variable differs from the default. Fix this by setting them to a static empty string.
The printouts for verbosity level D_USER_FILES are to be done exactly at this verbosity.
linas
reviewed
May 30, 2024
| @@ -83,10 +83,11 @@ void find_history_filepath(const char *dictname, const char *argv0, | |||
| prt_error("Warning: xdg_get_home(XDG_BD_STATE) failed; " | |||
| "input history will not be supported.\n"); | |||
| history_file = strdup("dev/null"); | |||
| return; | |||
| } | |||
|
|
|||
| history_file = hfile; | |||
There was a problem hiding this comment.
else is needed here. I'll put it in.
There was a problem hiding this comment.
I have just noted that I had a typo in "dev/null" (missing initial /).
EDIT: Fixed in PR #1538.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
save_default_opts(): Bugfix saving string defaultsFix the defaults for the verbosity and string parse-options.
make_dirpath(: Bugfix dir memory leak on MS Windowslg_readline.c: At verbosity 4, print the history file location--quiteIn addition:
D_USER_FILESThe intention is to show file paths only at this level and not at higher levels.