Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store the compartment for created metabolites #1420

Merged
merged 4 commits into from
Jan 8, 2025
Merged

Store the compartment for created metabolites #1420

merged 4 commits into from
Jan 8, 2025

Conversation

oxinabox
Copy link
Contributor

@oxinabox oxinabox commented Dec 13, 2024 •
edited
Loading

cdiener
cdiener requested changes Jan 7, 2025
View reviewed changes
Copy link
Member

@cdiener cdiener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The linter was complaining about a docstring.

tests/test_core/test_core_reaction.py Show resolved Hide resolved
@cdiener
Copy link
Member

cdiener commented Jan 7, 2025

There was another small issue with the logic in Reaction.build_reaction_from_string. Let me know if the changes are fine with you.

@oxinabox
Copy link
Contributor Author

oxinabox commented Jan 7, 2025

lgtm

@cdiener cdiener merged commit e5fc6ed into opencobra:devel Jan 8, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdiener cdiener cdiener approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] When a new metabolite is created during build_reaction_from_string it's compartment is not set
2 participants
@oxinabox @cdiener