Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add UKV #226

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

add UKV #226

wants to merge 7 commits into from
+94 −10

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Jan 21, 2025 •
edited
Loading

Pull Request

Description

Add UKV MO model. This has x and y as main dims, with lat and lot as a grid.

  • this gets new results every hour
    Current we have dropped lat and lon, but perhaps it would be good to save these too TODO

We might need to add #222 so that not data is not pulled twice

openclimatefix/ocf-infrastructure#697

How Has This Been Tested?

  • ran locally

  • added a test

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield changed the title Ukv add UKV Jan 21, 2025
@peterdudfield peterdudfield marked this pull request as draft January 21, 2025 19:14
@peterdudfield peterdudfield requested a review from devsjc January 21, 2025 19:15
@peterdudfield
Copy link
Contributor Author

This is my first try at this @devsjc, I wonder if you could have a look and advise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devsjc devsjc Awaiting requested review from devsjc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@peterdudfield