feat(ecmwf): Add full ensemble model #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterdudfield
approved these changes
Jan 15, 2025
| @@ -165,6 +165,33 @@ class Models: | |||
| ) | |||
| """Summary statistics from ECMWF's Ensemble Forecast System.""" | |||
|
|
|||
| ECMWF_ENS_0P1DEGREE: ModelMetadata = ModelMetadata( | |||
There was a problem hiding this comment.
do you need to add a test?
There was a problem hiding this comment.
or a github issue for a test?
There was a problem hiding this comment.
The methods on the entity itself are tested but each instantiation of the entity isn't - what would you want to test? That the fields are as expected?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables pulling full ensemble data from MARS.