add test

openclimatefix · Jan 21, 2025 · fac7a79 · fac7a79
1 parent 0d646eb
commit fac7a79
Show file tree

Hide file tree

Showing 3 changed files with 42 additions and 1 deletion.
diff --git a/src/nwp_consumer/internal/repositories/raw_repositories/mo_datahub.py b/src/nwp_consumer/internal/repositories/raw_repositories/mo_datahub.py
@@ -304,7 +304,7 @@ def _convert(path: pathlib.Path) -> ResultE[list[xr.DataArray]]:
                     errors="ignore",
                 )
                 .transpose(*MetOfficeDatahubRawRepository.model().expected_coordinates.dims))
-            print('ccc')
+
             if "latitude" in MetOfficeDatahubRawRepository.model().expected_coordinates.dims:
                 da = da.sortby(variables=["step", "variable", "longitude"])
                 da = da.sortby(variables="latitude", ascending=False)

diff --git a/...itories/raw_repositories/test_gribs/test_MO_UKV_agl_relative-humidity_1.5_2025012112.grib b/...itories/raw_repositories/test_gribs/test_MO_UKV_agl_relative-humidity_1.5_2025012112.grib
diff --git a/src/nwp_consumer/internal/repositories/raw_repositories/test_mo_datahub.py b/src/nwp_consumer/internal/repositories/raw_repositories/test_mo_datahub.py
@@ -3,6 +3,7 @@
 import os
 import pathlib
 import unittest
+from unittest.mock import patch
 
 from returns.result import Failure, ResultE, Success
 
@@ -89,3 +90,43 @@ class TestCase:
                 else:
                     self.assertIsInstance(region_result, Success, msg=f"{region_result}")
 
+        @patch.dict(os.environ, {"MODEL": "UKV"}, clear=True)
+        def test_convert_ukv(self) -> None:
+
+            @dataclasses.dataclass
+            class TestCase:
+                filename: str
+                expected_coords: NWPDimensionCoordinateMap
+                should_error: bool
+
+            tests: list[TestCase] = [
+                TestCase(
+                    filename="test_MO_UKV_agl_relative-humidity_1.5_2025012112.grib",
+                    expected_coords=dataclasses.replace(
+                        MetOfficeDatahubRawRepository.model().expected_coordinates,
+                        init_time=[dt.datetime(2025, 1, 21, 12, tzinfo=dt.UTC)],
+                        variable=[Parameter.TEMPERATURE_SL],
+                        step=[0],
+                    ),
+                    should_error=False,
+                ),
+            ]
+
+            for t in tests:
+                with self.subTest(name=t.filename):
+                    # Attempt to convert the file
+                    result = MetOfficeDatahubRawRepository._convert(
+                        path=pathlib.Path(__file__).parent.absolute() / "test_gribs" / t.filename,
+                    )
+                    region_result: ResultE[dict[str, slice]] = result.do(
+                        region
+                        for das in result
+                        for da in das
+                        for region in NWPDimensionCoordinateMap.from_xarray(da).bind(
+                            t.expected_coords.determine_region,
+                        )
+                    )
+                    if t.should_error:
+                        self.assertIsInstance(region_result, Failure, msg=f"{region_result}")
+                    else:
+                        self.assertIsInstance(region_result, Success, msg=f"{region_result}")