Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ecto 3.12 incompatability #105

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Conversation

novaugust
Copy link

removes private api usage

@peake100
Copy link
Contributor

peake100 commented Sep 7, 2024

Thanks for the PR!

@peake100
Copy link
Contributor

peake100 commented Sep 7, 2024

Would you mind closing this PR and reopening against dev instead? CI is set to run on the dev branch, then cut a release to main when dev is updated.

Copy link
Contributor

@peake100 peake100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above

@novaugust novaugust changed the base branch from main to dev September 9, 2024 14:20
@novaugust
Copy link
Author

Would you mind closing this PR and reopening against dev instead? CI is set to run on the dev branch, then cut a release to main when dev is updated.

edited! for future reference, you can hit "edit" on the PR and change which branch it's pointed at.

@peake100
Copy link
Contributor

peake100 commented Sep 9, 2024

Hey! Sorry, I should have been a little more clear. Your branch is still based on main, which includes some build artifacts not found in dev. You can see them in the diff.

Do you mind targeting your fork's dev to the main repo's dev?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants