-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make videos in cutting view larger #1337
base: main
Are you sure you want to change the base?
Conversation
This pull request is deployed at test.editor.opencast.org/1337/2024-05-13_10-22-57/ . |
Makes the video(s) in the cutting view a bit larger.
7b858f5
to
a9dfe3b
Compare
This pull request is deployed at test.editor.opencast.org/1337/2024-05-13_11-50-16/ . |
From the Dev meeting: This causes scrolling for quite a few people, which is kind of annoying. 😅 |
So ideally we ensure that there is no scrolling on the Cutting page (at least for common resolutions), while still having the videos take up more space? I can look into that. |
This pull request is deployed at test.editor.opencast.org/1337/2024-05-23_06-38-36/ . |
The difference is Safari is likely related to another issue that was very recently fixed here #1383 |
I have heard feedback that the video(s) in the cutting view are too small since the redesign. Therefore, this PR makes them slightly larger, but not as screen filling as before. Since this change focuses on design first and foremost, discussion would be appreciated on whether we want larger video(s) and if this might inconvenience current users somehow.
Current:
Larger: