Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make videos in cutting view larger #1337

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Arnei
Copy link
Member

@Arnei Arnei commented May 13, 2024

I have heard feedback that the video(s) in the cutting view are too small since the redesign. Therefore, this PR makes them slightly larger, but not as screen filling as before. Since this change focuses on design first and foremost, discussion would be appreciated on whether we want larger video(s) and if this might inconvenience current users somehow.

Current:
Bildschirmfoto vom 2024-05-13 12-15-46

Larger:
Bildschirmfoto vom 2024-05-13 13-49-06

@Arnei Arnei added the type:visual-clarity A part of the UI is not visually readable label May 13, 2024
Copy link

This pull request is deployed at test.editor.opencast.org/1337/2024-05-13_10-22-57/ .
It might take a few minutes for it to become available.

Makes the video(s) in the cutting view a bit larger.
@Arnei Arnei force-pushed the make-videos-bigger-again branch from 7b858f5 to a9dfe3b Compare May 13, 2024 11:49
Copy link

This pull request is deployed at test.editor.opencast.org/1337/2024-05-13_11-50-16/ .
It might take a few minutes for it to become available.

@KatrinIhler
Copy link
Member

From the Dev meeting: This causes scrolling for quite a few people, which is kind of annoying. 😅

@lkiesow
Copy link
Member

lkiesow commented May 14, 2024

Looking at your first image, I agree that there is unused space we can use.

But looking at this on my 16:9 display, this pull request now causes the controls to be hidden and I have to scroll within the editor. That's really not great:

Screenshot from 2024-05-14 17-54-31

↑↑↑ controls are hidden here. Not great.

@Arnei
Copy link
Member Author

Arnei commented May 17, 2024

So ideally we ensure that there is no scrolling on the Cutting page (at least for common resolutions), while still having the videos take up more space? I can look into that.

Copy link

This pull request is deployed at test.editor.opencast.org/1337/2024-05-23_06-38-36/ .
It might take a few minutes for it to become available.

@snoesberger
Copy link
Contributor

The videos look much smaller in Safari than in Firefox, for example.

Safari:
grafik

Firefox:
grafik

By the way, even now, without this PR, the videos are much smaller in Safari than they are in other browsers.

@Arnei
Copy link
Member Author

Arnei commented Jun 14, 2024

The difference is Safari is likely related to another issue that was very recently fixed here #1383

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:visual-clarity A part of the UI is not visually readable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants