Fix subtiles not saved for new subtitles #1267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Putting our selectors into ´createSlice` caused one of the selectors to be called incorrectly. This fixes that.
Creating a new subtitle from scratch was broken, because the text in the cues was not saved to Opencast. This fixes that.
Arnei
force-pushed
the
fix-subtitles-not-getting-saved-to-opencast-for-new-subtitles
branch
from
c38d383
to
1681ee8
Compare
|
This pull request is deployed at test.editor.opencast.org/1267/2024-02-01_09-37-13/ . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a new subtitle from scratch was broken, because the text in the cues was not saved to Opencast.
This fixes that.
Includes #1266.
Should also fix #888.