Skip to content

Commit

Permalink
Merge pull request #1258 from Arnei/eslint-couple-more-rules
Browse files Browse the repository at this point in the history
Remove already enforced eslint exceptions
  • Loading branch information
Arnei authored Jan 18, 2024
2 parents 468b878 + ca513d5 commit 5a83665
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 13 deletions.
12 changes: 1 addition & 11 deletions .eslintrc.js
Original file line number Diff line number Diff line change
@@ -1,21 +1,11 @@
module.exports = {
extends: [
"@opencast/eslint-config-ts-react",
"react-app/jest"
"react-app/jest",
],
rules: {
// "always" gives 319 warning, "never" gives 991.
"object-curly-spacing": "off",

// Currently 120 warnings.
"@typescript-eslint/no-explicit-any": "off",

// `else` in new line is used often, and often an `if` condition is on the
// same line as `{`.
"brace-style": "off",

// Until we figure out how to get to React 18
"react/no-deprecated": "off",
},
overrides: [
{
Expand Down
3 changes: 1 addition & 2 deletions src/main/Timeline.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -479,8 +479,7 @@ export const Waveforms: React.FC<{ timelineHeight: number; }> = ({ timelineHeigh
// Display a flatline
<div css={{ width: "100%" }}><hr /></div>
);
}
else {
} else {
return (
<>
<LuLoader css={[spinningStyle, { fontSize: 40 }]} />
Expand Down

0 comments on commit 5a83665

Please sign in to comment.